Skip to content

feat: remove the project agent and model setup - #7820

Closed
ronishrohan wants to merge 6 commits into
feat/session-owned-agentfrom
feat/session-owned-agent-ui
Closed

ronishrohan wants to merge 6 commits into
feat/session-owned-agentfrom
feat/session-owned-agent-ui

Conversation

@ronishrohan

@ronishrohan ronishrohan commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

What this changes for users

Creating a local project no longer asks for a worker agent, an orchestrator agent or models. Pick a folder and the project is created, then you land in the orchestrator chat. Local project settings lose the agent and model pickers. An agent is chosen per session and can be switched at any time.

Defaults follow the same order as PR 1: the remembered ready agent, else the first ready one in claude-code, codex, cursor, opencode.

Stacked on #7711. Review that first. Only the local app changes; cloud projects and the mobile app keep their current agent setup.

What was removed

  • Frontend: the local "Set up project" agent step, the agent and model pickers in local project settings, useProjectDefaultWorker, and the orchestratorAgent field on workspace summaries.
  • Backend: project model, effort and mode no longer reach a session. Project config contributes permissions only. Summary.OrchestratorAgent and DefaultWorkerReviewer are gone, and legacy import no longer maps agent or model.
  • CLI: --worker-agent and --orchestrator-agent are hidden, deprecated no-ops.
  • Docs: new "Choosing and switching agents" guide replaces the per-role agents page.

Compatibility

  • The API decodes projects with DisallowUnknownFields, so the legacy agent, model, effort and mode fields stay in the schema. They are ignored and stripped on create, update and set-config. Deleting them is a later breaking-API cleanup.
  • Remote hosts on an older AO: those daemons still need a project agent to start the orchestrator. When adding a project on a remote host, the desktop sends the host's default agent (first authorized in the priority order) in the deprecated role fields. Current daemons strip it; older ones use it. If the agent list cannot be read, nothing extra is sent.
  • Cloud: project creation and settings keep their worker and orchestrator agent pickers, and settings still require both.

Review notes

  • Existing local projects' saved model, effort and mode are now dropped for new sessions. Existing sessions keep their own saved model on restore.
  • Many frontend and e2e tests were rewritten without a local run. CI is the first run.

🤖 Generated with Claude Code

ronishrohan and others added 3 commits November 4, 2026 11:55
Project config now contributes only role permissions to a spawn. Legacy
worker/orchestrator agent, model, effort and mode are ignored and stripped on
every write; the schema still accepts them so older clients keep working.

- Drop DefaultWorkerReviewer; the reviewer follows the worker's own agent.
- Remove Summary.orchestratorAgent and regenerate the API files.
- Make --worker-agent and --orchestrator-agent hidden deprecated no-ops.
- Legacy import no longer maps agent or model into project config.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BAocjNsUtdxZ78MGF2WNDp
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BAocjNsUtdxZ78MGF2WNDp
- Creating a local project no longer asks for agents; the setup dialog only
  appears for tracker intake, a repository setup notice, or a failed create.
- Project settings drop the worker/orchestrator agent, model, mode and effort
  rows and keep approval and reviewer settings. Cloud keeps its rows.
- The new-chat composer preselects the last ready agent, then the first ready
  agent in priority order, ignoring any old project pin.
- Remove orchestratorAgent from the workspace model and the unused i18n keys.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BAocjNsUtdxZ78MGF2WNDp
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

🏆 Review leaderboard

Oct 29, 2026–Nov 5, 2026 · UTC

Rank Reviewer PRs reviewed Review rounds PR comments
🥇 @ronishrohan @ronishrohan 52 95 16
🥈 @Vaibhaav-Tiwari @Vaibhaav-Tiwari 39 62 10
🥉 @Rishet11 @Rishet11 29 48 61
4 @nikhilachale @nikhilachale 12 69 3
5 @somewherelostt @somewherelostt 12 51 1
6 @Prasad-D-Ware @Prasad-D-Ware 10 13 0
7 @Meraj-08 @Meraj-08 9 21 4
8 @illegalcall @illegalcall 8 16 2
9 @harshitsinghbhandari @harshitsinghbhandari 5 10 0
10 @neversettle17-101 @neversettle17-101 5 7 2

Ranked by distinct external PRs reviewed, then review rounds, then PR comments. Self-activity and bot activity are excluded.

Show 8 more reviewers
Rank Reviewer PRs reviewed Review rounds PR comments
11 @Pritom14 @Pritom14 5 6 5
12 @ApexYash11 @ApexYash11 4 13 2
13 @Annieeeee11 @Annieeeee11 3 5 2
14 @mohakchakraborty2004 @mohakchakraborty2004 3 4 0
15 @codebanditssss @codebanditssss 3 3 1
16 @Vansh-Singhal @Vansh-Singhal 1 3 1
17 @wesleymatosdev @wesleymatosdev 1 2 1
18 @AgentWrapper @AgentWrapper 1 1 0

@OrcInc OrcInc added comp/desktop Electron main process and React renderer. enhancement New feature or request labels Nov 5, 2026
@OrcInc OrcInc added this to the Agents & orchestration milestone Nov 5, 2026
ronishrohan and others added 2 commits November 10, 2026 18:56
…trator-36/sa-ui

# Conflicts:
#	frontend/src/renderer/components/CloudProjectSettingsForm.tsx
#	frontend/src/renderer/components/ProjectSettingsEditor.tsx
Adding a project no longer asks for agents, and the orchestrator spawn
names none. A remote host on an AO version from before this change still
needs a project agent, so its orchestrator would fail to start.

When adding a project on a remote host, the desktop now also sends the
host's default agent (first authorized one in the default priority) in
the deprecated worker/orchestrator agent fields. Current daemons strip
those fields on write, so nothing changes for them. If the agent list
cannot be read, nothing extra is sent.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ent-ui

Conflict resolutions keep main's new work and this branch's removal of
project agent and model setup:
- keep main's session import, settings layout, icons, actions slot,
  docs renames and the new provisioning test
- drop main's additions that read the removed project pins: the effort
  inheritance test, the agent retry test, workspace.orchestratorAgent
  reads (fall back to the orchestrator session's own agent)
- useProjectDefaultWorker and the project agent e2e spec stay deleted
- tests use main's "Orchestrator agent approval" label

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ronishrohan

Copy link
Copy Markdown
Collaborator Author

Closing in favor of #8252. Rather than removing project agent settings, new projects now start on the most preferred agent and can still be changed in project settings. The branch is kept for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron main process and React renderer. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants