Skip to content

fix: steady the new-project handoff to the orchestrator chat - #7821

Closed
ronishrohan wants to merge 6 commits into
feat/session-owned-agent-uifrom
feat/session-owned-agent-cloud
Closed

ronishrohan wants to merge 6 commits into
feat/session-owned-agent-uifrom
feat/session-owned-agent-cloud

Conversation

@ronishrohan

@ronishrohan ronishrohan commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

What this changes for users

Creating a local project is steadier. The screen no longer flips to the Board between the new-chat screen and the orchestrator chat, and the starter chips and top-bar buttons no longer pop in at the handoff.

Stacked on #7711 and #7820. Review those first.

How it works

  • provisionOrchestrator now navigates to the session before releasing the starting chat, so the provisioning gate stays up until the session route has landed.
  • The starting chat shows the starter chips, and its top bar reserves the editor and cue buttons as disabled placeholders.

Scope change

This PR used to also move cloud projects and the mobile app off project agents. That is taken back here, so the stack only changes the local app:

  • the cloud contract, cloud-client schema and cloud docs match main
  • cloud project creation and settings still pick and require agents
  • cloud task launch, artifact sessions and orchestrator spawn use the project's pinned agent as before
  • the mobile spawn sheet matches main

The live control plane (ao-control-plane) rejects a stored role without an agent (unsupported Cloud agent "") and defaults orchestrator-spawned workers to claude-code, so cloud and mobile need their own PRs together with a control-plane change.

Review notes

  • The handoff fix was checked by recording project creation in the dev app before this scope change.

🤖 Generated with Claude Code

ronishrohan and others added 3 commits November 4, 2026 11:59
- ProjectRoleConfig.agent is optional and deprecated, role model, mode and
  effort are deprecated; permissions keep their meaning.
- Mobile seeds a spawn from the ranked first selectable agent, never from
  project config, and the spawn model stays Automatic unless picked.
- Document that a cloud session's agent is chosen when it starts.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BAocjNsUtdxZ78MGF2WNDp
- Creating a cloud project no longer asks for worker and orchestrator agents.
- Cloud project settings keep approval and reviewer rows only, and the PATCH
  sends permissions without an agent.
- Cloud orchestrator, artifact and composer defaults use one helper,
  defaultCloudAgent: claude-code, then codex, cursor, opencode among the
  connected providers. The Codex-first orchestrator preference is gone.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BAocjNsUtdxZ78MGF2WNDp
…rator chat

The project route's board showed through for a beat because the starting
chat was released before the navigation to the orchestrator session
landed. Starting screen now matches the session: same starter chips and
a topbar cluster that already holds the editor and cue controls.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BAocjNsUtdxZ78MGF2WNDp
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

🏆 Review leaderboard

Oct 29, 2026–Nov 5, 2026 · UTC

Rank Reviewer PRs reviewed Review rounds PR comments
🥇 @ronishrohan @ronishrohan 52 95 16
🥈 @Vaibhaav-Tiwari @Vaibhaav-Tiwari 39 62 10
🥉 @Rishet11 @Rishet11 29 48 61
4 @nikhilachale @nikhilachale 12 69 3
5 @somewherelostt @somewherelostt 12 51 1
6 @Prasad-D-Ware @Prasad-D-Ware 10 13 0
7 @Meraj-08 @Meraj-08 9 21 4
8 @illegalcall @illegalcall 8 16 2
9 @harshitsinghbhandari @harshitsinghbhandari 5 10 0
10 @neversettle17-101 @neversettle17-101 5 7 2

Ranked by distinct external PRs reviewed, then review rounds, then PR comments. Self-activity and bot activity are excluded.

Show 8 more reviewers
Rank Reviewer PRs reviewed Review rounds PR comments
11 @Pritom14 @Pritom14 5 6 5
12 @ApexYash11 @ApexYash11 4 13 2
13 @Annieeeee11 @Annieeeee11 3 5 2
14 @mohakchakraborty2004 @mohakchakraborty2004 3 4 0
15 @codebanditssss @codebanditssss 3 3 1
16 @Vansh-Singhal @Vansh-Singhal 1 3 1
17 @wesleymatosdev @wesleymatosdev 1 2 1
18 @AgentWrapper @AgentWrapper 1 1 0

@OrcInc OrcInc added comp/desktop Electron main process and React renderer. enhancement New feature or request labels Nov 5, 2026
@OrcInc OrcInc added this to the Agents & orchestration milestone Nov 5, 2026
ronishrohan and others added 2 commits November 10, 2026 18:56
Merges the updated project-setup removal branch and takes back this PR's
cloud and mobile changes, so the stack only changes the local app:

- cloud contract, cloud-client schema and cloud docs are back to main
- cloud project creation and settings still pick and require agents
- cloud task launch, artifact sessions and orchestrator spawn use the
  project's pinned agent as before
- the mobile spawn sheet is back to main

The new-project handoff fix stays. Cloud and mobile move to their own
PRs once the control plane accepts projects without role agents.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ronishrohan ronishrohan changed the title feat: cloud and mobile stop pinning an agent, steadier new-project handoff fix: steady the new-project handoff to the orchestrator chat Nov 10, 2026
…-agent-cloud

SessionTopbarActions: main rebuilt the top bar (TopbarButton is gone, icons
come from app-icons). The starting-orchestrator placeholders now use main's
Button and ghost pill, matching TopbarOpenEditorButton and CueRunMenu, and
sit where those controls appear once the session lands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ronishrohan

Copy link
Copy Markdown
Collaborator Author

Closing in favor of #8252. Rather than removing project agent settings, new projects now start on the most preferred agent and can still be changed in project settings. The branch is kept for reference.

ronishrohan added a commit that referenced this pull request Nov 12, 2026
…tor chat

Adding a project now goes straight to the orchestrator chat, which made
the handoff's flicker more visible:

- the starting screen stays up until the session route has landed, so the
  Board no longer shows for a beat in between;
- the starter chips show while the orchestrator starts (clicks are
  ignored until it is ready), so they don't pop in at the handoff;
- the top bar reserves the editor and cue buttons as disabled
  placeholders, so the cluster doesn't widen when the session lands.

Ported from the closed #7821.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ronishrohan added a commit that referenced this pull request Nov 12, 2026
…oper Mode) (#8252)

* feat(projects): start new projects on the most preferred agent

New projects no longer ask for a worker and orchestrator agent. The
renderer ranks agents from the cached readiness snapshot: installed,
signed-in agents first, then ones AO has not checked yet, each ordered by
AO's integration priority (Claude Code, Codex, Cursor, OpenCode, ...).
Missing or signed-out agents are left out. The worker, orchestrator and
reviewer all start on the top agent (the reviewer on the best agent that
can review), with Claude Code as the fallback when nothing is usable.

The setup sheet now opens only for tracker intake, a repository setup
notice, or a failed create; otherwise the project is created as soon as
its folder is chosen. Agent checks refresh while the flow is open.
Project settings keep the agent and model controls unchanged. Cloud
projects are not affected.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(projects): steady the handoff from a new project to its orchestrator chat

Adding a project now goes straight to the orchestrator chat, which made
the handoff's flicker more visible:

- the starting screen stays up until the session route has landed, so the
  Board no longer shows for a beat in between;
- the starter chips show while the orchestrator starts (clicks are
  ignored until it is ready), so they don't pop in at the handoff;
- the top bar reserves the editor and cue buttons as disabled
  placeholders, so the cluster doesn't widen when the session lands.

Ported from the closed #7821.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(chat): keep one composer placeholder while an orchestrator starts

A local orchestrator start runs its steps in a second or two, and the
composer named each one as it ran ("Getting your project ready",
"Getting the latest code", "Preparing your workspace", "Running your
project setup", "Connecting to your orchestrator"), then said "Restoring
your conversation" on its first connect though there was nothing to
restore. The placeholder flickered through all of them.

An orchestrator start now reads "Starting your orchestrator" from the
first frame until it is ready. "Restoring your conversation" stays for
chats that have history.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(projects): address review of the new-project agent defaults

- Reviewer: follow the daemon's own rule (the top agent only when it is
  an unattended-safe reviewer, otherwise Claude Code) instead of pinning
  any reviewer-capable agent, which bypassed explicit selection and could
  be unknown to an older remote host.
- Top bar: the starting placeholders follow their real controls, so a
  remote host reserves no editor or cue slot and a cloud project no
  editor slot; the bar no longer shrinks when those sessions land.
- Starter prompts: stay visible only while an orchestrator starts; other
  fenced chats (unreachable host, leaving for the terminal) keep them
  hidden as before.
- Tests: Sidebar tests no longer pick agents in the setup sheet; e2e
  specs create without the sheet or turn on tracker intake where they
  exercise it; the sheet agent-picker spec is removed with the pickers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(projects): wait for agent checks before ranking an unchecked snapshot

A project is now created right after its folder is picked. If the renderer's
readiness snapshot predates the daemon's first checks, every agent reads "not
checked" and the ranking fell to priority order, starting the project on
Claude Code even when only Codex is installed. When the most preferred usable
agent is not confirmed yet, wait for the daemon's checks before ranking.

Also: a failed navigation after the orchestrator spawned no longer reports
the start as failed, and the starter-prompt comment says what picks do.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(settings): open Settings above the create sheet without its agent field

The create sheet no longer has agent pickers, so this test could not reach
Settings through the Worker agent field's management menu and failed in CI.
Open Settings with the same store call agent management makes, and check the
sheet's intake draft survives the round trip.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(projects): keep the setup sheet up while settings load

Picking a folder before settings loaded opened only the flow's backdrop: the
sheet waited to learn whether tracker intake applied, with no dialog or way
out during the request and its retries. Show the sheet while settings load
(its Back and close still cancel) and hold Create until intake is known; it
then either asks for intake or steps aside for the automatic create.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(chat): disable sample requests while new work is unavailable

While an orchestrator starts (or another chat is fenced off), the sample
request chips stayed enabled and focusable but did nothing when picked. Mark
them disabled whenever picks are ignored, so they show and expose that state.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(projects): review with the best installed safe reviewer

When the top agent could not review unattended (Cursor, Aider, Gemini, ...),
the reviewer fell straight to Claude Code even when it was not installed, so
reviews failed to start. Pick the most preferred unattended-safe reviewer the
machine has instead, and fall back to Claude Code only when it has none.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(projects): keep automatic project agents behind Developer Mode

With Developer Mode off, creating a project works as on main again: the
setup sheet asks for the worker and orchestrator agents, preselected from
recent session history, and nothing is created until Create is pressed.

With Developer Mode on, the new flow from this PR applies: no agent
pickers, the project starts on the most preferred ready agent (reviewer
included), and the sheet only appears for intake, Git setup, or an error.

The orchestrator handoff, steady placeholder, and sample-request fixes
stay on for everyone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron main process and React renderer. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants