Repository navigation
Conversation
Contributor
|
Hi @LoisRForgeFlow, @kittiu, |
OCA-git-bot
added
mod:base_tier_validation
added 2 commits
October 6, 2026 23:18
A new option under Validated by: Any of specific users. The definition lists the users, and any one of them can validate, like a member of a reviewer group, without creating a group for them. The Four-eyes Principle applies to it as well, and so does the access warning. The reviews already store a list of reviewers, so approving, the systray and corrections work unchanged. Specific user stays as it is, so nothing changes for existing definitions or modules that use reviewer_id.
…eview A forwarded review is for the user it is forwarded to, not for the users listed on the definition.
bosd
force-pushed
the
19.0-imp-base_tier_validation-any-of-users
branch
from
October 6, 2026 21:18
2043536 to
e188ae9
Compare
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a third option under Validated by: Any of specific users. The definition lists the users, and any one of them can validate, like a member of a reviewer group, but without having to create a group for them.
The reviews already store a list of reviewers (that is how group reviews work, and why a correction can put two people on a review), so approving, the systray, digests and corrections work unchanged. The Four-eyes Principle applies to this option too, and the reviewer access warning checks the listed users.
Specific user (
reviewer_id) stays as it is, so existing definitions and modules or data that setreviewer_idare unaffected. Merging both into one multi-user field would be cleaner, but needs a migration; I'd keep that for 20.0.Tests cover: any listed user validates, editing the list updates open reviews, four-eyes, the form, and (in
base_tier_validation_forward) that a forwarded review is only for the user it is forwarded to.Draft: the form part will conflict with #23 (which reorganises the same form); I'll rebase once #23 is merged.