19.0: open PRs to get in before the 20.0 migration #96

Hi @LoisRForgeFlow,

The 20.0 migration has started (#94, #95). I still have quite a few 19.0 PRs open, and I'd like to get as much as possible into 19.0 before the migration moves on, so that it doesn't have to be redone or ported later. Here's an overview, roughly in the order I'd suggest:

Approved, ready to merge

• [19.0][IMP] base_tier_validation: UI clean-up #23 UI clean-up of the tier definition form. Several PRs below build on its layout.
• [19.0][IMP] base_tier_validation: late / pending / future systray buckets #41 late / pending / future buckets in the systray
• [19.0][FIX] base_tier_validation: systray recount cost grows with the reviewer's backlog #59 systray recount cost grows with the backlog

Bug fixes, mostly small

• base: [19.0][FIX] base_tier_validation: comment support approve_sequence_bypass #37, [19.0][FIX] base_tier_validation: recompute can_review when a sibling review changes status #54, [19.0][FIX] base_tier_validation: no reminders for reviews still waiting #71, [19.0][FIX] base_tier_validation: same order for tiers with the same sequence #80, [19.0][FW] base_tier_validation: error on simple form views without header #84 (forward-port of an 18.0 fix), [19.0][FIX] base_tier_validation: no access to reviews for portal and public users #85 (portal/public users could read all reviews through RPC)
• correction: [19.0][FIX] base_tier_validation_correction: restrict resource_ref to tier-validated models #34, [19.0][FIX] base_tier_validation_correction: honest revert via snapshot #45, [19.0][FIX] base_tier_validation_correction: Scheduled Action and Affected Tier Reviews buttons #73, [19.0][FIX] base_tier_validation_correction: cancel only before applying #77
• forward: [19.0][FIX] base_tier_validation_forward: forward notification delivery #38
• others: [19.0][FIX] account_move_tier_validation: allow resequencing journal entries #65, [19.0][FIX] sale_tier_validation: customers can sign approved quotations #87, [19.0][FIX] account_move_tier_validation: OCR of Odoo Enterprise on reviewed bills #89, [19.0][FIX] base_tier_validation_formula: check the expressions on save #90

Small improvements

• [19.0][IMP] base_tier_validation_correction: UI polish #27, [19.0][IMP] base_tier_validation: chatter warning at request_validation if reviewers lack access #32, [19.0][IMP] base_tier_validation: smart-button on validated documents #33, [19.0][IMP] base_tier_validation: validation progress indicator #35, [19.0][REF] base_tier_validation: rewrite tier_review_widget collapse with native <details> #44, [19.0][IMP] base_tier_validation_correction: safer Prepare #75, [19.0][IMP] base_tier_validation: only internal users as tier reviewer #78, [19.0][IMP] base_tier_validation_forward: only internal users as next reviewer #79, [19.0][IMP] base_tier_validation: rewrite the documentation #86 (documentation)

New modules and migrations (independent of the rest)

• [19.0][MIG] base_tier_validation_board: Migration to 19.0 #40 board, and [19.0][ADD] tier_validation_digest #25 digest which depends on it
• [19.0][MIG] base_tier_validation_delegation #68 delegation, and [19.0][MIG] base_tier_validation_delegation_log #69 / [19.0][MIG] base_tier_validation_delegation_hr #70 which depend on it
• [19.0][ADD] account_move_tier_validation_purchase + _stock_landed_costs #26, [19.0][ADD] contract_tier_validation #66

Features that can wait for 20.0 if needed

• [19.0][ADD] base_tier_validation: tier.definition.allow_reject for sign-off tiers #42, [19.0][ADD] base_tier_validation: allow_bulk_approve on tier.definition #46, [19.0][ADD] base_tier_validation: dedicated manager group, menu out of Technical #47, [19.0][IMP] base_tier_validation: clearer, self-checking tier definitions #48, and the drafts [19.0][ADD] base_tier_validation_correction: kanban view grouped by state #29, [19.0][IMP] base_tier_validation: restrict who can restart a validation #83, [19.0][IMP] base_tier_validation: validated by any of specific users #91

I know it's a long list. If it's easier, I can bundle the small cosmetic ones into a single PR. Reviews from others are very welcome too: any PR from the first three groups helps.

Thanks!