Repository navigation
Conversation
Contributor
|
Hi @LoisRForgeFlow, |
OCA-git-bot
added
mod:base_tier_validation
This was referenced Oct 3, 2026
added 2 commits
October 6, 2026 19:06
The reminder cron picked reviews in waiting as well as pending. A waiting review sits behind an earlier tier of an "approve by sequence" chain: the reviewer cannot act on it yet, but was reminded to anyway, every few days. Remind pending reviews only. A review that becomes pending is reminded at the next run, since it has been open longer than the delay.
…views Now that waiting reviews get no reminder, the help can say what happens: a reminder every so many days while the review is pending.
bosd
force-pushed
the
19.0-fix-base_tier_validation-reminder-waiting
branch
from
October 6, 2026 17:08
137eec6 to
f03d4e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reminder cron picked reviews in waiting as well as pending. With Approve by sequence, a waiting review sits behind an earlier tier: the reviewer can't act on it yet, but got reminded anyway, every few days.
Now only pending reviews are reminded. When a waiting review becomes pending, it is reminded at the next cron run, because it has already been open longer than the delay.
The new test fails without the fix: the second tier gets a reminder while it is still waiting.
Independent of #39 (batch limit in the same cron). They merge cleanly in either order, and the suite passes with both.
A second commit updates the help of the reminder delay to say it is about pending reviews, which is true once this fix is in. #23 rewrites the same help line; whichever merges second gets a one-line conflict, which I'll resolve.