installer: Fix store mtime - #16558
Merged
Merged
Conversation
xokdvium
commented
Oct 3, 2026
Comment on lines
+197
to
+200
| # BusyBox tar is bad at preserving mtime because it doesn't seem to do the correct | ||
| # thing of doing a final fixup pass for fixing parent directory permissions and doesn't | ||
| # handle symlinks at all. So we can set the correct mtime here. | ||
| find "$dest/store/$i" -depth -exec touch -hmd "@1" {} + |
…st names This ports the same hack as in the nix-installer repo to make test derivation names not get dropped on the floor by DrvName extraction logic (which treated everything after the dash - including the install case description - as part of the "version").
…taller repo Aligns the test better to what's in the nix-installer repo and adds support for custom checks for cases with some common tests.
It's 1, not 0 (see mtimeStore). Also busybox tar is busted at preserving mtime, so hack around the issue by setting the correct mtime ourselves.
xokdvium
force-pushed
the
fix-installer-mtime
branch
from
October 3, 2026 18:42
70761c1 to
4620eab
Compare
Ericson2314
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The are several issues:
touchthe store object recursively to force the correct mtime manually. Done in-depthorder.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.