Repository navigation
Fix store mtime, work around tar-rs bug - #240
Merged
Merged
Conversation
Mirrors the fixes to the scripted installer. Sadly tar-rs is buggy and doesn't fixup directory permissions at the end, so we have to do it manually. Files and symlinks seem to be handled correctly with the directories being the only buggy entry type. Use filetime crate like tar-rs is using because stdlib doesn't seem to have a stable alternative.
xokdvium
force-pushed
the
store-mtime-fix
branch
from
October 4, 2026 20:12
137d6df to
95f9296
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mirrors the fixes to the scripted installer (NixOS/nix#16558). Sadly tar-rs is buggy and doesn't fixup directory permissions at the end, so we have to do it manually. Files and symlinks seem to be handled correctly with the directories being the only buggy entry type.
Use filetime crate like tar-rs is using because stdlib doesn't seem to have a stable alternative.
Checklist