Skip to content

feat: MGR strategy for single phase flow + ALM poromechanics - #4125

Merged
victorapm merged 48 commits into
developfrom
feature/paludettomag1/ALM-singlephase
Aug 28, 2026
Merged

feat: MGR strategy for single phase flow + ALM poromechanics#4125
victorapm merged 48 commits into
developfrom
feature/paludettomag1/ALM-singlephase

Conversation

@victorapm

@victorapm victorapm commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Completes the fully implicit single-phase poromechanics + conforming-fractures ALM path started in #3961 and the MGR recipe work in #3962.

On top of #3961 / #3962, this PR adds:

  • Production-ready coupled sparsity: setSparsityPattern builds the exact union of flow and mechanics patterns (incl. well/perforation blocks for reservoir-and-wells)
  • Per-mesh-body dR/dAperture row offsets through assembleHydrofracFluxTerms (fixes multi-body row aliasing); reject unsupported multi-target setups
  • Dedicated ALM kernels and a nested MGR strategy for the displacement/bubble F-block
  • singlePhasePoromechanicsConformingFracturesALMReservoirFVM MGR strategy that eliminates the well block on a third level
  • hypredrive near-null space from rigid-body modes (six vectors per mesh body)
  • Shared appendSparsityPattern utility and tighter ALM MGR field/thermal guards

jafranc and others added 30 commits February 2, 2026 13:59
@jafranc
first pass
bd68d98
@npillardou
Add FIM coupling for single phase fracture ALM
8b2fc7f
@jafranc
missing guards
dedd57e
@jafranc
Merge commit '8b2fc7f10411c61baf85f5d7ceca8087840586dc' into jafranc/…
0a29b7b 
…feat/ALMreciepe
@npillardou
Add fix to fracture state in case of high cohesion
9143dd1
@npillardou
Correct traction in limit
616626b
@npillardou
Add fix on synchronization for ghost issue remaining
24cf0ef
@jhuang2601
uncrustify
68d789c
@jafranc
Merge remote-tracking branch 'origin/fix/ALM-cohesion-stick-slip-bug'…
552cb9c 
… into jafranc/feat/ALMreciepe
@npillardou
Update with other branch
c381048
@npillardou
Correct sign convention + hardcoded constitutive
edac1f9
@npillardou
Correct sparsity pattern
889de70
@jafranc
Merge remote-tracking branch 'origin/develop' into jafranc/feat/ALMre…
fa6fe03 
…ciepe
@npillardou
Change MGR config
b877903
@jafranc
Revert "Change MGR config"
02cf3e1 
This reverts commit b877903.
@jafranc
Merge remote-tracking branch 'origin/develop' into jafranc/feat/ALMre…
f20ccca 
…ciepe
@jhuang2601
Merge branch 'develop' into feature/npillardou/SinglePhasePoromechani…
6721e09 
…csConformingFracturesALM-FullyImplicit
@jhuang2601
Merge branch 'develop' into feature/npillardou/SinglePhasePoromechani…
70f565b 
…csConformingFracturesALM-FullyImplicit
@npillardou
Add missing A^bp coupling term
1759535
@victorapm
Merge branch 'develop' into feature/paludettomag1/ALM-singlephase
edfbf9f
@victorapm
Fix VTK mesh redistribution
11d6133
@victorapm
Improve ALM HypreDrive support
39f04b1
@victorapm
Improved MGR strategy for SinglePhasePoromechanicsConformingFracturesALM
68fe9d5
@victorapm
Merge remote-tracking branch 'origin/develop' into jafranc/feat/ALMre…
ab89e2b 
…ciepe

# Conflicts:
#	src/coreComponents/linearAlgebra/utilities/LinearSolverParameters.hpp
@victorapm
Fix compilation error
bf48697
@victorapm
Add missing MGR strategy bridge
4c29442
@victorapm
Add compatibility with vtk 9.6.2
35205fa
@victorapm
Fix bug in the fully coupled ALM + single-phase sparsity construction
8fe08f2 
  - The mechanics solver replaced the existing flow sparsity pattern, discarding flow and custom FIM couplings.
  - Pressure–bubble couplings checked for the nonexistent wrapper bubbleElementsList instead of the registered bubbleCells key.

Fixed both by unioning the flow and mechanics patterns before adding FIM couplings, and by using the correct wrapper key
@victorapm
Fix SIGFPE issue
1cba563
@jafranc
Merge remote-tracking branch 'origin/feature/paludettomag1/ALM-single…
bccf477 
…phase' into jafranc/feat/ALMreciepe
@victorapm victorapm added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Aug 18, 2026
@victorapm victorapm added the flag: no rebaseline Does not require rebaseline label Aug 18, 2026
@victorapm victorapm added the ci: run code coverage enables running of the code coverage CI jobs label Aug 18, 2026
jafranc
jafranc approved these changes Aug 19, 2026
View reviewed changes

@jafranc jafranc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @victorapm 👍
Nice utilities introduced here in addition to the core enabling of MGR for 1p-ALM contact

jhuang2601
jhuang2601 approved these changes Aug 19, 2026
View reviewed changes

@jhuang2601 jhuang2601 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @victorapm for adding mgr recipe for ALM with FIM coupling.
It is working well for two analytical examples (slanted fault and vertical fault).

frankfeifan
frankfeifan approved these changes Aug 21, 2026
View reviewed changes

@frankfeifan frankfeifan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Thanks!

Comment thread src/coreComponents/physicsSolvers/multiphysics/HydrofractureSolver.cpp
void HydrofractureSolver< POROMECHANICS_SOLVER >::setUpDflux_dApertureMatrix( DomainPartition & domain,
DofManager const & dofManager,
CRSMatrix< real64, globalIndex > & localMatrix )
void HydrofractureSolver< POROMECHANICS_SOLVER >::setUpDflux_dApertureMatrix( DomainPartition & domain )

@frankfeifan frankfeifan Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setUpDflux_dApertureMatrix now exists in three solvers, and their differences look small. I think it is possible to do some refactor (maybe in another PR) and pull into a share utility hearder at some point to save duplicated lines.

@victorapm victorapm Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Frank, good point. @jafranc is working on refactoring the LM/ALM codes, maybe your suggestion can go in?

@frankfeifan frankfeifan Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting me know! I'll port this comment there.

@victorapm
victorapm requested a review from joshua-white August 24, 2026 15:03
@frankfeifan frankfeifan mentioned this pull request Aug 27, 2026
Open
@victorapm

victorapm commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Needs code owner review and we're ready to merge

@herve-gross

herve-gross commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

@OmarDuran thanks for taking a look

@victorapm victorapm added the ci: run device builds Allows to run the device (CUDA/HIP) builds label Aug 28, 2026
OmarDuran
OmarDuran reviewed Aug 28, 2026
View reviewed changes
Comment thread src/coreComponents/linearAlgebra/interfaces/hypre/hypredrive.cpp Outdated
OmarDuran
OmarDuran approved these changes Aug 28, 2026
View reviewed changes

@OmarDuran OmarDuran left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @victorapm, I left one minor suggestion and one potential suggestion.

Comment thread src/coreComponents/physicsSolvers/multiphysics/HydrofractureSolver.cpp
victorapm and others added 3 commits August 28, 2026 01:21
@victorapm
victorapm merged commit d83bf22 into develop Aug 28, 2026
22 checks passed
@victorapm
victorapm deleted the feature/paludettomag1/ALM-singlephase branch August 28, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frankfeifan frankfeifan frankfeifan approved these changes
@OmarDuran OmarDuran OmarDuran approved these changes
@jafranc jafranc jafranc approved these changes
@jhuang2601 jhuang2601 jhuang2601 approved these changes
@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner
@tjb-ltk tjb-ltk Awaiting requested review from tjb-ltk tjb-ltk is a code owner
@dkachuma dkachuma Awaiting requested review from dkachuma dkachuma is a code owner
@MelReyCG MelReyCG Awaiting requested review from MelReyCG MelReyCG is a code owner
@bd713 bd713 Awaiting requested review from bd713 bd713 is a code owner
@wrtobin wrtobin Awaiting requested review from wrtobin wrtobin is a code owner
@corbett5 corbett5 Awaiting requested review from corbett5 corbett5 is a code owner
@joshua-white joshua-white Awaiting requested review from joshua-white

Assignees

@victorapm victorapm

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run device builds Allows to run the device (CUDA/HIP) builds ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@victorapm @herve-gross @OmarDuran @frankfeifan @jafranc @jhuang2601 @npillardou