feat: Enable thermal HydroFracture simulation - #4129
Open
frankfeifan wants to merge 50 commits into
Open
Conversation
… into jafranc/feat/ALMreciepe
This reverts commit b877903.
…csConformingFracturesALM-FullyImplicit
…csConformingFracturesALM-FullyImplicit
…ciepe # Conflicts: # src/coreComponents/linearAlgebra/utilities/LinearSolverParameters.hpp
- The mechanics solver replaced the existing flow sparsity pattern, discarding flow and custom FIM couplings. - Pressure–bubble couplings checked for the nonexistent wrapper bubbleElementsList instead of the registered bubbleCells key. Fixed both by unioning the flow and mechanics patterns before adding FIM couplings, and by using the correct wrapper key
…phase' into jafranc/feat/ALMreciepe
…phase' into feature/frankfei/thmHydroFrac
frankfeifan
requested review from
MelReyCG,
corbett5,
cssherman,
dkachuma,
jafranc,
kimtaeho07,
victorapm and
wrtobin
as code owners
August 27, 2026 06:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to enable thermal run for the
HydroFracturesolver and has made following changes:applyInitialConditions()exactly once after the initial fracture elements are created inSurfaceGeneratorto apply initial conditions on the initial crack, otherwise, the fracture initial condition cannot be applied as the node is only split after the common initial condition is applied.massCreationwhen the new fracture element is born to emulate the treatment onmassCreationin the mass conservation equation._nstate of newly created elements (fluiddensity_n/internalEnergy_n) so an element's mass and energy balances agree at birth instead of one starting from zero.This PR is based on #4125 for the new treatment on allocating
dRdAperturein the matrix.Comparison for the non-poroelastic rock-only matrix (noThermalStress means

defaultDrainedLinearTEC=0)Comparison for the poroelastic matrix (noThermalStress means

defaultDrainedLinearTEC=0)