Skip to content

Read the pulsar_std node catalogue directly, without PBGC - #36

Merged
Tuafo merged 1 commit into
mainfrom
claude/cool-hypatia-ict23g
Oct 15, 2026
Merged

Tuafo merged 1 commit into
mainfrom
claude/cool-hypatia-ict23g

Conversation

@Tuafo

@Tuafo Tuafo commented Oct 15, 2026

Copy link
Copy Markdown
Member

PBGC had shrunk to a single module that converts pulsar_std's #[blueprint] registry into Graphy node metadata, and this plugin was its only user. This PR moves that conversion into the plugin, so PBGC can be removed.

Changes

  • New src/std_nodes.rs with the conversion code taken from PBGC's metadata.rs. It exposes extract_node_metadata, node_metadata (built once on first use) and StdNodeProvider, Graphy's NodeMetadataProvider for the data-flow checks.
  • The three call sites (palette loading, the validation stage and the compiler's preflight check) now use it.
  • The plugin depends on pulsar_std directly instead of on PBGC. The rev is the same Pulsar-Native rev the other Pulsar-Native dependencies use.
  • PBGC's three tests are now tests/std_nodes.rs.
  • Comments that described PBGC as the source of the metadata now name pulsar_std or Graphy.

extract_node_metadata never fails, so its Result is gone. So are PBGC's helpers that nothing here called (get_categories, get_nodes_by_category, find_node).

This also fixes the check that failed on Far-Beyond-Pulsar/PBGC#12. That PR's standalone build used an old pulsar_std whose delay node had no Completed exec output. The plugin builds against the current one, and the test passes.

Pulsar-Native drops the PBGC submodule and pins this branch in a companion PR (link below).

Checked

Inside a Pulsar-Native checkout with PBGC removed:

  • cargo test -p blueprint_editor_plugin --tests: io_formats 8 pass, std_nodes 3 pass.
  • rustfmt --check passes on the touched files.

🤖 Generated with Claude Code

https://claude.ai/code/session_01RXesb588JFPYCDBnK94vn5


Generated by Claude Code

PBGC had shrunk to one module that turns pulsar_std's #[blueprint]
registry into Graphy node metadata, and this plugin was its only user.
That conversion now lives here (src/std_nodes.rs), with PBGC's three
tests, and the plugin depends on pulsar_std directly.

Building against the current pulsar_std also fixes the check PBGC#12
failed: `delay` has its `Completed` exec output.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RXesb588JFPYCDBnK94vn5
@Tuafo Tuafo self-assigned this Oct 15, 2026
@Tuafo Tuafo moved this from Todo to In Progress in Pulsar Tracker Oct 15, 2026
@Tuafo
Tuafo merged commit 50396e2 into main Oct 15, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from In Progress to Pending Release in Pulsar Tracker Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending Release

Development

Successfully merging this pull request may close these issues.

2 participants