Skip to content

Reduce PBGC to the pulsar_std node catalogue (0.2.0) - #12

Closed
Tuafo wants to merge 2 commits into
mainfrom
refactor/metadata-only
Closed

Tuafo wants to merge 2 commits into
mainfrom
refactor/metadata-only

Conversation

@Tuafo

@Tuafo Tuafo commented Oct 14, 2026

Copy link
Copy Markdown
Member

This opens the PR for the existing refactor/metadata-only branch (8108764, Tristan's commit from 2026-10-02). It doesn't change the branch.

Pulsar-Native has pinned crates/third-party/pbgc to this commit since then. Because the commit isn't on PBGC's main, it is the one entry in Pulsar-Native's .github/submodule-pin-exceptions.txt: "PBGC branch refactor/metadata-only; no upstream PR yet". Once this merges, Pulsar-Native can pin the merge commit and drop that exception.

What the branch does, from its commit message: it removes the bytecode compiler, the VM and the graph-to-Rust backend, leaving the pulsar_std node catalogue. Blueprint graphs now compile to script modules (blueprint_compiler), and the Rust export is generated from those (pulsar_script_codegen).

It merges cleanly with main, and the merged tree is identical to the branch tip. Main's only commit not on the branch is the merge of #11, whose files the branch removes.

🤖 Generated with Claude Code

https://claude.ai/code/session_01RXesb588JFPYCDBnK94vn5


Generated by Claude Code

tristanpoland and others added 2 commits September 2, 2026 15:06
Removes the bytecode compiler and VM and the graph-to-Rust backend: Blueprint
graphs compile to script modules (blueprint_compiler) and the Rust export is
generated from them (pulsar_script_codegen).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Tuafo commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

build fails in tests/metadata.rs. flow_intrinsics_keep_their_exec_pins expects delay to have the exec output Completed and finds none.

The cause is the pulsar_std pin. This repository's CI builds against pulsar_std at Pulsar-Native 38bbbd93. At that revision delay was still a blocking thread::sleep with no exec pins; Completed arrived later, in Pulsar-Native e9776a0c1. Inside Pulsar-Native the test passes, because there PBGC uses the workspace's current pulsar_std.

Moving the pin to current Pulsar-Native main isn't enough on its own; I tried it:

  • cargo update -p libc is needed to resolve.
  • After that, pulsar_script_vm fails to compile because two copies of pulsar_reflection end up in the graph. One comes from Pulsar-Native's submodule, the other from SceneDB's Pulsar-Reflection pin.

So a standalone build would also need [patch] entries that resolve both copies to one Pulsar-Reflection revision, the way Pulsar-Native's root manifest does. The alternative is to build this crate inside a Pulsar-Native checkout, as Plugin_Shaders' CI does.

I haven't pushed either to this branch, since the branch is Tristan's. Say which approach you prefer and I'll make the change.


Generated by Claude Code

@Tuafo Tuafo self-assigned this Oct 15, 2026
@Tuafo

Tuafo commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

@tristanpoland

Tuafo commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

I'm closing this without merging. PBGC is no longer needed.

After this branch, PBGC was only the pulsar_std → Graphy metadata converter, and the Blueprint editor was its only user. That converter now lives in the plugin (Far-Beyond-Pulsar/Plugin_Blueprints#36), and Pulsar-Native removes the PBGC submodule in Far-Beyond-Pulsar/Pulsar-Native#1387.

That also takes care of the failing build here. The plugin builds against the current pulsar_std, where delay has its Completed exec output, and the moved test passes.

The refactor/metadata-only branch is left as it was. Once #1387 merges, the repository could be archived if you want.


Generated by Claude Code

@Tuafo Tuafo closed this Oct 15, 2026
@github-project-automation github-project-automation Bot moved this from In Progress to Pending Release in Pulsar Tracker Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending Release

Development

Successfully merging this pull request may close these issues.

2 participants