Repository navigation
fix(app): read leftover product names from the brand hook - #3572
Conversation
A few user-facing strings still say ClickStack or HyperDX, so a downstream brand swap does not change them. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
PR Review✅ No issues found. |
Deep Review✅ No critical issues found. This is a tightly scoped, low-risk change: four React components swap hardcoded 🔵 P3 nitpicks (1)
Reviewers (8): correctness, testing, maintainability, project-standards, kieran-typescript, previous-comments, agent-native, learnings-researcher. Testing gaps: No render/snapshot test asserts the banner renders No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
E2E Test Results✅ All tests passed • 461 passed • 1 skipped • 1535s
Tests ran across 4 shards in parallel. |
Summary
The ClickStack brand migration still left a few user-facing strings hardcoded as ClickStack or HyperDX. A downstream build that replaces
src/brand/does not change them. These now go throughuseBrandDisplayNameorusePageTitle. Doc URLs are unchanged./careerstitle, and "Join us to build {brand} at ClickHouse"Package names, the HyperDX browser SDK, Terraform provider copy, and comments are left as they are.
Screenshots or video
Not captured in this session. The table is left for a visual check.
How to reproduce
Starting point: play.hyperdx.io, or
yarn app:dev:localconnected to the demo server. The ClickHouse-build banner only shows whenIS_CLICKHOUSE_BUILDis set.On
main:/careers. The document title is "Careers | HyperDX" and the intro says "build ClickStack".On this branch:
How to test on Vercel preview
Preview routes: /careers, /search, /chart
Steps:
References
Made with Cursor