Skip to content

fix(app): read leftover product names from the brand hook - #3572

Merged
kodiakhq[bot] merged 1 commit into
mainfrom
elizabet/use-brand-display-name
Nov 5, 2026
Merged

kodiakhq[bot] merged 1 commit into
mainfrom
elizabet/use-brand-display-name

Conversation

@elizabetdev

Copy link
Copy Markdown
Member

Summary

The ClickStack brand migration still left a few user-facing strings hardcoded as ClickStack or HyperDX. A downstream build that replaces src/brand/ does not change them. These now go through useBrandDisplayName or usePageTitle. Doc URLs are unchanged.

  • ClickHouse-build banner: "{brand} features…" and the "{brand} docs" link
  • /careers title, and "Join us to build {brand} at ClickHouse"
  • Raw SQL chart help: "{brand} documentation"
  • Search syntax reference tooltip: "{brand} search documentation"

Package names, the HyperDX browser SDK, Terraform provider copy, and comments are left as they are.

Screenshots or video

Not captured in this session. The table is left for a visual check.

Before After
Hardcoded ClickStack / HyperDX Brand display name

How to reproduce

Starting point: play.hyperdx.io, or yarn app:dev:local connected to the demo server. The ClickHouse-build banner only shows when IS_CLICKHOUSE_BUILD is set.

On main:

  1. Open /careers. The document title is "Careers | HyperDX" and the intro says "build ClickStack".
  2. Open Search, then the help icon labeled "Open syntax reference". The external-link tooltip says "ClickStack search documentation".
  3. Open Chart Explorer on a raw SQL chart and expand "SQL Chart Instructions". The link says "ClickStack documentation".
  4. In a ClickHouse build, the top banner says "lacking core ClickStack features" and links "ClickStack Docs".

On this branch:

  1. Repeat the same steps. Each of those names is the brand display name (ClickStack in this repo).

How to test on Vercel preview

Preview routes: /careers, /search, /chart

Steps:

  1. Open /careers and confirm the intro says the brand name rather than a hardcoded "ClickStack", and the tab title is "Careers - {brand}".
  2. Open /search, click the search help icon ("Open syntax reference"), and hover the external-link icon. Confirm the tooltip uses the brand name.
  3. Open /chart, switch to a raw SQL chart, expand "SQL Chart Instructions", and confirm the documentation link uses the brand name.

References

Made with Cursor

A few user-facing strings still say ClickStack or HyperDX, so a
downstream brand swap does not change them.

Co-authored-by: Cursor <cursoragent@cursor.com>
@elizabetdev
elizabetdev requested a review from a team as a code owner November 5, 2026 17:52
@elizabetdev
elizabetdev requested a review from teeohhem November 5, 2026 17:52
@vercel

vercel Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hyperdx-oss Ready Ready Preview Nov 5, 2026 5:55pm UTC
hyperdx-storybook Ready Ready Preview Nov 5, 2026 5:55pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 55b8ea4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 4
  • Production lines changed: 26
  • Branch: elizabet/use-brand-display-name
  • Author: elizabetdev

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Duplicate code analysis

No new duplicate code introduced by this PR.


jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 110 in total (1.22%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

PR Review

✅ No issues found.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found. This is a tightly scoped, low-risk change: four React components swap hardcoded ClickStack/HyperDX display strings for the useBrandDisplayName / usePageTitle hooks already used across ~15 pages. Hook calls are unconditional and correctly placed, the removed INSTANCE_TITLE_SUFFIX import is genuinely unused, and the {' '} whitespace in the banner renders core ClickStack features correctly. The CareersPage tab-title move to usePageTitle('Careers') aligns it with every other page, and leaving doc URLs and the clickstack-banner-state storage key untouched is correct.

🔵 P3 nitpicks (1)
  • .changeset/ — no changeset accompanies this user-facing @hyperdx/app change, which the repo's AGENTS.md PR-hygiene convention calls for and the changeset bot flagged.
    • Fix: Add a patch changeset for @hyperdx/app describing the brand-string update.
    • previous-comments, project-standards

Reviewers (8): correctness, testing, maintainability, project-standards, kieran-typescript, previous-comments, agent-native, learnings-researcher.

Testing gaps: No render/snapshot test asserts the banner renders core ClickStack features with the {' '} separator; an accidental removal of {' '} would silently concatenate to coreClickStack with no test to catch it.

No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

E2E Test Results

✅ All tests passed • 461 passed • 1 skipped • 1535s

Status Count
✅ Passed 461
❌ Failed 0
⚠️ Flaky 3
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

@kodiakhq
kodiakhq Bot merged commit 62d76c0 into main Nov 5, 2026
32 checks passed
@kodiakhq
kodiakhq Bot deleted the elizabet/use-brand-display-name branch November 5, 2026 18:27

This branch was successfully deployed

2 active deployments
Preview – hyperdx-oss — 55b8ea42 Deployed Nov 5, 2026 by vercel[bot]
Preview – hyperdx-storybook — 55b8ea42 Deployed Nov 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants