Repository navigation
Commit 62d76c0
authored
fix(app): read leftover product names from the brand hook (#3572)
## Summary
The ClickStack brand migration still left a few user-facing strings hardcoded as ClickStack or HyperDX. A downstream build that replaces `src/brand/` does not change them. These now go through `useBrandDisplayName` or `usePageTitle`. Doc URLs are unchanged.
- ClickHouse-build banner: "{brand} features…" and the "{brand} docs" link
- `/careers` title, and "Join us to build {brand} at ClickHouse"
- Raw SQL chart help: "{brand} documentation"
- Search syntax reference tooltip: "{brand} search documentation"
Package names, the HyperDX browser SDK, Terraform provider copy, and comments are left as they are.
### Screenshots or video
Not captured in this session. The table is left for a visual check.
| Before | After |
| :----- | :---- |
| Hardcoded ClickStack / HyperDX | Brand display name |
### How to reproduce
**Starting point:** [play.hyperdx.io](https://play.hyperdx.io), or `yarn app:dev:local` connected to the demo server. The ClickHouse-build banner only shows when `IS_CLICKHOUSE_BUILD` is set.
**On `main`:**
1. Open `/careers`. The document title is "Careers | HyperDX" and the intro says "build ClickStack".
2. Open Search, then the help icon labeled "Open syntax reference". The external-link tooltip says "ClickStack search documentation".
3. Open Chart Explorer on a raw SQL chart and expand "SQL Chart Instructions". The link says "ClickStack documentation".
4. In a ClickHouse build, the top banner says "lacking core ClickStack features" and links "ClickStack Docs".
**On this branch:**
1. Repeat the same steps. Each of those names is the brand display name (ClickStack in this repo).
### How to test on Vercel preview
**Preview routes:** /careers, /search, /chart
**Steps:**
1. Open /careers and confirm the intro says the brand name rather than a hardcoded "ClickStack", and the tab title is "Careers - {brand}".
2. Open /search, click the search help icon ("Open syntax reference"), and hover the external-link icon. Confirm the tooltip uses the brand name.
3. Open /chart, switch to a raw SQL chart, expand "SQL Chart Instructions", and confirm the documentation link uses the brand name.
### References
- Related PRs: #3545
- Linear Issue:
Made with [Cursor](https://cursor.com)1 parent ab36d4e commit 62d76c0
4 files changed
Lines changed: 18 additions & 8 deletions
File tree
- packages/app/src
- components
- ChartEditor
- SearchInput
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
81 | 82 | | |
82 | 83 | | |
83 | 84 | | |
| 85 | + | |
| 86 | + | |
84 | 87 | | |
85 | 88 | | |
86 | 89 | | |
| |||
92 | 95 | | |
93 | 96 | | |
94 | 97 | | |
95 | | - | |
| 98 | + | |
96 | 99 | | |
97 | 100 | | |
98 | 101 | | |
99 | 102 | | |
100 | 103 | | |
101 | 104 | | |
102 | | - | |
| 105 | + | |
103 | 106 | | |
104 | 107 | | |
105 | 108 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| |||
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
| 37 | + | |
36 | 38 | | |
37 | 39 | | |
38 | 40 | | |
| |||
79 | 81 | | |
80 | 82 | | |
81 | 83 | | |
82 | | - | |
| 84 | + | |
83 | 85 | | |
84 | 86 | | |
85 | 87 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
| |||
292 | 294 | | |
293 | 295 | | |
294 | 296 | | |
| 297 | + | |
295 | 298 | | |
296 | 299 | | |
297 | 300 | | |
| |||
336 | 339 | | |
337 | 340 | | |
338 | 341 | | |
339 | | - | |
| 342 | + | |
340 | 343 | | |
341 | 344 | | |
342 | 345 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
| 34 | + | |
33 | 35 | | |
34 | 36 | | |
35 | 37 | | |
| |||
58 | 60 | | |
59 | 61 | | |
60 | 62 | | |
61 | | - | |
62 | | - | |
| 63 | + | |
| 64 | + | |
63 | 65 | | |
64 | 66 | | |
65 | 67 | | |
66 | 68 | | |
67 | 69 | | |
68 | 70 | | |
69 | 71 | | |
70 | | - | |
| 72 | + | |
71 | 73 | | |
72 | 74 | | |
73 | 75 | | |
| |||
0 commit comments