Skip to content

Name output accessors after socket names and generate shader Attribute - #269

Merged
BradyAJohnston merged 1 commit into
mainfrom
output-names-from-socket-names
Oct 12, 2026
Merged

BradyAJohnston merged 1 commit into
mainfrom
output-names-from-socket-names

Conversation

@BradyAJohnston

Copy link
Copy Markdown
Owner

Generated o.<name> attributes now use the socket's display name (falling back to the identifier when a name is shared), matching what to_python writes, e.g. o.fac → o.factor, Points().o.points, Selection().o.boolean. Old identifier names still resolve at runtime.

The shader Attribute node is now generated instead of hand-written, with a customization keeping attribute_name positional in its factories.

@codspeed

codspeed Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

⚠️ 2 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

✅ 15 untouched benchmarks


Comparing output-names-from-socket-names (9931175) with main (927e458)

Open in CodSpeed

@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.30%. Comparing base (927e458) to head (9931175).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
- Coverage   98.31%   98.30%   -0.01%     
==========================================
  Files         106      106              
  Lines       31175    31175              
==========================================
- Hits        30649    30648       -1     
- Misses        526      527       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BradyAJohnston
BradyAJohnston force-pushed the output-names-from-socket-names branch from 14f4ebc to d02648c Compare October 12, 2026 13:55
@BradyAJohnston
BradyAJohnston changed the base branch from main to vector-dimensions-before-value October 12, 2026 13:55
@BradyAJohnston
BradyAJohnston added this pull request to stack #272 October 12, 2026 13:59
@BradyAJohnston
BradyAJohnston force-pushed the output-names-from-socket-names branch from d02648c to 8ebd372 Compare October 12, 2026 14:01
Base automatically changed from vector-dimensions-before-value to main October 12, 2026 14:11
@BradyAJohnston
BradyAJohnston force-pushed the output-names-from-socket-names branch from 8ebd372 to 9931175 Compare October 12, 2026 14:11
@BradyAJohnston
BradyAJohnston merged commit 0a86f39 into main Oct 12, 2026
8 checks passed
@BradyAJohnston
BradyAJohnston deleted the output-names-from-socket-names branch October 12, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant