Repository navigation
Name output accessors after socket names and generate shader Attribute - #269
Merged
Merged
Conversation
Contributor
Merging this PR will not alter performance
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
==========================================
- Coverage 98.31% 98.30% -0.01%
==========================================
Files 106 106
Lines 31175 31175
==========================================
- Hits 30649 30648 -1
- Misses 526 527 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
BradyAJohnston
force-pushed
the
output-names-from-socket-names
branch
from
October 12, 2026 13:55
14f4ebc to
d02648c
Compare
BradyAJohnston
changed the base branch from
main
to
vector-dimensions-before-value
October 12, 2026 13:55
BradyAJohnston
added this pull request to stack #272
October 12, 2026 13:59
BradyAJohnston
force-pushed
the
output-names-from-socket-names
branch
from
October 12, 2026 14:01
d02648c to
8ebd372
Compare
BradyAJohnston
force-pushed
the
output-names-from-socket-names
branch
from
October 12, 2026 14:11
8ebd372 to
9931175
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated
o.<name>attributes now use the socket's display name (falling back to the identifier when a name is shared), matching whatto_pythonwrites, e.g.o.fac→o.factor,Points().o.points,Selection().o.boolean. Old identifier names still resolve at runtime.The shader
Attributenode is now generated instead of hand-written, with a customization keepingattribute_namepositional in its factories.