Skip to content

Name input parameters after socket names - #273

Merged
BradyAJohnston merged 4 commits into
mainfrom
input-names-from-socket-names
Oct 12, 2026
Merged

BradyAJohnston merged 4 commits into
mainfrom
input-names-from-socket-names

Conversation

@BradyAJohnston

Copy link
Copy Markdown
Owner

Constructor and factory parameters, i.<name> and to_python now use the socket's display name, as #269 does for outputs (ColorRamp(factor=), GeometryProximity(geometry=, sample_position=), group_id=, …). Old keywords still work with a DeprecationWarning (removed in 530).

@codspeed

codspeed Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

⚠️ 1 benchmark spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

✅ 15 untouched benchmarks


Comparing input-names-from-socket-names (ad94cee) with main (0a86f39)

Open in CodSpeed

@codecov

codecov Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.46809% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.31%. Comparing base (0a86f39) to head (ad94cee).

Files with missing lines Patch % Lines
src/nodebpy/export/codegen.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         106      106           
  Lines       31175    31251   +76     
=======================================
+ Hits        30649    30725   +76     
  Misses        526      526           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BradyAJohnston
BradyAJohnston merged commit 67a9955 into main Oct 12, 2026
11 checks passed
@BradyAJohnston
BradyAJohnston deleted the input-names-from-socket-names branch October 12, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant