Repository navigation
Make socket operators match Python on integers - #245
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
==========================================
- Coverage 98.34% 98.34% -0.01%
==========================================
Files 101 101
Lines 30286 30307 +21
==========================================
+ Hits 29786 29806 +20
- Misses 500 501 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
# Conflicts: # docs/changelog.qmd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
tests/test_operator_evaluation.py, which evaluates each operator in a tree (via databpy, now a dev dependency) and compares it with Python on the same values. It found:&,|,^,~built Boolean Math, casting to booleans (i | 4raised). They now build Bit Math.%was truncated modulo (-7 % 3 == -1). Now floored, like Python and float%. Breaking./truncated (7 / 3 == 2). Now a float Math divide returning aFloatSocket;//stays integer division. Breaking.int_socket < float_socketcompared the operands the wrong way round after type promotion.Codegen lifts follow: Bit Math to
&/|/^/~, floored modulo to%, and the guards keep Boolean Math fed by integers (and the reverse) as calls.