Repository navigation
Add socket methods across vector, scalar, color, grid, bundle and data-block sockets - #247
Closed
BradyAJohnston wants to merge 7 commits into
Closed
BradyAJohnston wants to merge 7 commits into
BradyAJohnston wants to merge 7 commits into
Conversation
# Conflicts: # docs/changelog.qmd
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
- Coverage 98.34% 98.30% -0.05%
==========================================
Files 101 101
Lines 30283 30572 +289
==========================================
+ Hits 29783 30055 +272
- Misses 500 517 +17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #245 and #244 (merged into this branch); the diff shrinks to this PR's changes once those land.
min,max,floor,snap,wrap, trig,faceforward,refract, ...),to_spherical/to_cylindrical,project_point,euler_to_rotation.divide_round,divide_ceiling,gcd,lcm,to_float,shift/rotate(Bit Math; right shifts are logical). Float:smooth_min/smooth_max,inverse_sqrt,is_close.round(),math.floor/ceil/truncon float sockets return integer sockets (Float To Integer).gamma(). Color + color (and -, *, /) uses Mix and keeps alpha; with a scalar or vector a color still acts as a vector. Breaking for color-color arithmetic, which returned a vector.hash(seed)andblur()on the types their nodes support.set_background,set_transform,advect,sdf_union/sdf_intersect/sdf_difference.store,get.<type>,has,join/|(later bundle wins, checked by evaluation),paths; geometrybundle()/set_bundle().camera_info(),bone_info(), imageinfo(), collectionchildren(), materialselection().The exporter emits the methods where a spec can express them. Numeric methods are checked against Python/numpy in
tests/test_socket_method_evaluation.py.Found along the way: SDF Grid Boolean doesn't round-trip through codegen on main (#246).