feat(tx-manifest): add smplx transaction engine - #12
Merged
Merged
Conversation
Arvolear
reviewed
Sep 13, 2026
| const covenant = new smplx.Covenant(source, argumentsJson); | ||
|
|
||
| try { | ||
| return { |
Member
There was a problem hiding this comment.
We'll have to add support for state upon compilation here + return a CMR + tapleafhash.
Arvolear
reviewed
Sep 13, 2026
| } | ||
|
|
||
| /** Confirmation target for the fee estimate, in blocks. */ | ||
| const FEE_TARGET_BLOCKS = 6; |
Arvolear
reviewed
Sep 13, 2026
Comment on lines
+6
to
+8
| path = smplx | ||
| url = https://github.com/lukachi/smplx.git | ||
| branch = dev |
Arvolear
approved these changes
Sep 14, 2026
Arvolear
left a comment
Arvolear
left a comment
Member
There was a problem hiding this comment.
Will move these comments to dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
PR 3 of 9 in the manifest release train. This is stacked on #11; review only the delta from
feature/tx-manifest-review.What this slice delivers
8f0215cand integrates its real SDK 0.0.10 WASM packageDeliberate boundaries
This slice does not own wallet credentials, mnemonic access, signing, confidential outputs, covenant-spend inputs, broadcasting, or UI activation. Receive remains an explicit refusal when it reaches the unsupported covenant-input amount reference. Those capabilities arrive in later stacked PRs.
Verification
Verified from a clean detached worktree at this commit with LWK
693c4fb, smplx8f0215c, and the generated smplx SDK 0.0.10 package:The repository-wide root app typecheck is not used as this slice's gate: a clean frozen install currently exposes pre-existing duplicate React/Zod type-family failures in unrelated UI code. The focused workflow checks the entire surface owned here, and restoring the cumulative full-repository gate is tracked for the final activation/release slice.