feat(tx-manifest): resolve references and classes - #13
Merged
Merged
Conversation
Arvolear
reviewed
Sep 14, 2026
| * whereas a partially-read map would silently leave a parameter untyped, and an untyped parameter | ||
| * is one this wallet then declines to encode for a reason about the wrong thing. | ||
| */ | ||
| export function createSmplxContractParamTypes( |
Member
There was a problem hiding this comment.
Please rename everywhere.
Suggested change
| export function createSmplxContractParamTypes( | |
| export function createSmplxCovenantParamTypes( |
Arvolear
reviewed
Sep 14, 2026
Arvolear
reviewed
Sep 14, 2026
Arvolear
reviewed
Sep 14, 2026
| * These are not gaps waiting to be filled in by pattern. Each one names something the position | ||
| * does not say, and a value written there would have to be guessed at rather than read. | ||
| */ | ||
| const UNENCODABLE: Record<string, string> = { |
Member
There was a problem hiding this comment.
I don't fully understand that. Why can't we require a definite encoding here?
Arvolear
reviewed
Sep 14, 2026
| return { ok: false, reason: `"${text}" cannot be used as ${accepted.describes}.` }; | ||
| } | ||
|
|
||
| if (reference.deprecated) { |
Member
There was a problem hiding this comment.
I'd just remove any deprecated stuff.
Arvolear
reviewed
Sep 14, 2026
Comment on lines
+164
to
+167
| for (let round = 1; round <= ITERATION_BOUND; round += 1) { | ||
| const next: Record<string, string> = {}; | ||
|
|
||
| for (const { name, node, source } of computed) { |
Member
There was a problem hiding this comment.
I see this is O(n^2) complexity. Can this be rewritten via topological sort to acheive linear O(n) complexity?
Arvolear
approved these changes
Sep 14, 2026
Arvolear
left a comment
Arvolear
left a comment
Member
There was a problem hiding this comment.
Good for now. See the comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
PR 4 of 9 in the tx-manifest merge train.
feature/tx-manifest-engine(PR feat(tx-manifest): add smplx transaction engine #12)What this adds
compile_params.namespace by reference site.Review boundaries
This slice deliberately does not add:
Those remain in later stacked PRs.
Verification
Verified from commit
b994c0fin a clean detached worktree with the committed submodules:8f0215c, SDK package0.0.10bun run typecheck:packagesbun run lint(exit 0; existing repository warnings only)bun run format:checkbun test packages/tx-manifest apps/extension/src/core/chains/liquid/adapters/smplxThe repository-wide TypeScript gate has a pre-existing clean-install React/Zod duplicate-type baseline. This stack uses the focused tx-manifest/smplx gate until the cumulative activation/release slice restores and proves the full root check.