Repository navigation
refactor: drop the rlinf compatibility surface - #2
Conversation
The project is pre-release and every existing box reinstalls in the same
window as the vvla -> embodiinfer rename, so the compatibility layer only
kept the rlinf lineage visible:
- drop the rlinf-* console-script aliases and the rlinf_deploy shim module
- rename the control-plane schemas from rlinf.{control,simulation,teleop}.*
to embodirun.*.v1 and the device-io / observation / job thread names with
them
- move state, lock, and cache paths to embodirun names and rename the
RLINF_DEPLOY_* environment variables to EMBODIRUN_*
- drop the x-rlinf-* header fallbacks and the legacy repository alias table
RLinf stays referenced in the docs as the upstream training framework and in
the microduck asset inventory (that file name belongs to the upstream repo).
Breaking: existing boxes must reinstall and their control peers must move to
the renamed schemas in the same window as the vvla -> embodiinfer change.
The rename-tolerant checkout identity also kept mapping the internal repository names; boxes reinstall in the same window, so drop those aliases with the rest of the compatibility surface.
|
Reviewed commit Two non-blocking items:
Local validation used an isolated copy of the reviewed commit with Python 3.13 and the available dependencies: 1,015 tests passed and 40 were skipped. One additional integration test file ( |
anHappyDog
left a comment
There was a problem hiding this comment.
Reviewed commit 3ad828d. I found no blocking functional regressions within the PR's stated breaking-change scope; removal of the legacy rlinf interfaces is intentional. Two non-blocking follow-ups are noted inline.
Local validation used an isolated copy of the reviewed commit with Python 3.13 and the available dependencies: 1,015 tests passed and 40 were skipped. One additional integration test file (tests/test_embodiinfer_http_integration.py) was excluded because the pinned EmbodiInfer submodule was unavailable. Ruff lint and formatting checks passed. The installed core CLI commands and the Control, Simulation, and teleoperation module entry points also passed their --help checks.
Changing this review to feedback only; approval was not intended.
anHappyDog
left a comment
There was a problem hiding this comment.
Review feedback for commit 3ad828d. The previous approval has been withdrawn; this review records feedback only.
I found no blocking functional regressions within the PR's stated breaking-change scope. The two P3 suggestions remain in the existing inline comments:
- Keep CLI entry-point checks independent: parameterize the command checks so missing SGLang does not skip the Go2 entry-point check.
- Remove stale compatibility-alias wording: remove the obsolete README fragment and dangling compatibility-alias comments.
Local validation: 1,015 tests passed and 40 were skipped in an isolated checkout with Python 3.13 and the available dependencies. One additional integration test file was excluded because the pinned EmbodiInfer submodule was unavailable. Ruff lint and formatting checks, installed core CLI checks, and Control, Simulation, and teleoperation module entry-point checks passed.
anHappyDog
left a comment
There was a problem hiding this comment.
Addressed both P3 review comments in commit b155081.
- Parameterized the installed CLI checks. Missing SGLang now skips only its own case; the subsequent Go2 entry-point check runs and passes.
- Removed the stale compatibility-alias wording from the SGLang Pi05 README and the dangling comments from both integration package manifests.
Validation in the frozen Python 3.12 environment: 26 passed, 1 skipped across tests/test_branding.py and tests/test_inference_providers.py. The single skip is the optional SGLang check. Repository-wide Ruff lint and formatting checks and git diff --check passed.
Follow-up to PR #1 (vvla -> embodiinfer rename). Removes the rlinf compatibility layer entirely: CLI aliases, the rlinf_deploy shim module, rlinf.* control-plane schemas, rlinf-named state/lock/cache paths, RLINF_DEPLOY_* environment variables, and x-rlinf-* header fallbacks. RLinf remains only as the upstream training-framework name in docs and the microduck asset inventory. Breaking in the same window as the vvla -> embodiinfer rename; existing boxes reinstall in that window anyway.