Skip to content

Enable HTTPS endpoint identification in JsseSslEngineFactory #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperxpro merged 1 commit into from
Jul 18, 2026
+9 −0
Merged

Enable HTTPS endpoint identification in JsseSslEngineFactory #2243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions client/src/main/java/org/asynchttpclient/netty/ssl/JsseSslEngineFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import javax.net.ssl.SSLContext;
import javax.net.ssl.SSLEngine;
import javax.net.ssl.SSLParameters;

public class JsseSslEngineFactory extends SslEngineFactoryBase {

Expand All @@ -31,6 +32,14 @@ public JsseSslEngineFactory(SSLContext sslContext) {
@Override
public SSLEngine newSslEngine(AsyncHttpClientConfig config, String peerHost, int peerPort) {
SSLEngine sslEngine = sslContext.createSSLEngine(domain(peerHost), peerPort);
// A JDK SSLEngine does not verify the peer hostname unless the endpoint identification algorithm
// is set, so without this a certificate valid for any host would be accepted. Enable it to match
// DefaultSslEngineFactory, honoring disableHttpsEndpointIdentificationAlgorithm.
if (!config.isDisableHttpsEndpointIdentificationAlgorithm()) {
SSLParameters params = sslEngine.getSSLParameters();
params.setEndpointIdentificationAlgorithm("HTTPS");
sslEngine.setSSLParameters(params);
}
configureSslEngine(sslEngine, config);
return sslEngine;
}
Expand Down
Loading