Enable HTTPS endpoint identification in JsseSslEngineFactory#2243
Merged
Conversation
A JDK SSLEngine does not verify the peer hostname unless the endpoint identification algorithm is set, so JsseSslEngineFactory accepted a certificate valid for any host. DefaultSslEngineFactory already enables it. Set it here too, honoring disableHttpsEndpointIdentificationAlgorithm, so a custom JDK SSLContext no longer silently loses hostname verification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
JsseSslEngineFactorycreates theSSLEngineusingsslContext.createSSLEngine(host, port)but only enables client mode viasetUseClientMode(true). It never configures endpoint identification, so a JDKSSLEnginedoes not verify the server hostname during the TLS handshake. As a result, any certificate signed by a trusted CA is accepted regardless of the requested hostname, leaving the connection vulnerable to man-in-the-middle attacks.DefaultSslEngineFactorycorrectly enables hostname verification.This regression was introduced in #2104, which removed the shared
setEndpointIdentificationAlgorithm("HTTPS")call fromconfigureSslEngine()and restored it only inDefaultSslEngineFactory, unintentionally leaving the pure JSSE path (used with a user-supplied JDKSSLContext) without hostname verification.Modification
Update
JsseSslEngineFactory.newSslEngine()to configure the engine'sSSLParameterswithsetEndpointIdentificationAlgorithm("HTTPS"), unlessconfig.isDisableHttpsEndpointIdentificationAlgorithm()is enabled. This matches the behavior ofDefaultSslEngineFactorywhile preserving the documented opt-out.Result
Connections created through
JsseSslEngineFactorywith a custom JDKSSLContextnow perform hostname verification during the TLS handshake, matching the default implementation. Existing opt-out behavior remains unchanged, and theDefaultSslEngineFactorypath is unaffected.