Repository navigation
test(api): cover /v1/status and /v1/jobs read endpoints - #174
Merged
zc277584121 merged 1 commit intoJul 13, 2026
Merged
Conversation
These metadata-only endpoints go through eng().infra.meta and had no coverage, so the InfraStack refactor that dropped the Engine.meta forwarding property broke all three (500 "'Engine' object has no attribute 'meta'") without any test noticing; zilliztech#170 fixed the call sites. Drive them through a real TestClient lifespan against the tmp SQLite + Milvus Lite so the "endpoint wired to a stale handle" regression class stays caught.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
tests/test_api_status_jobs.py— a small regression guard driving the three metadata-only read endpoints through a realTestClientlifespan:GET /v1/status→200 {"connectors": [], "jobs": {}}GET /v1/jobs→200 []GET /v1/jobs/{missing}→404 not_foundWhy
These endpoints go through
eng().infra.metaand had no test coverage. When the InfraStack refactor (#164) dropped theEngine.metaforwarding property, the call sites inapi/app.pykept reading the removed attribute, so all three 500'd with'Engine' object has no attribute 'meta'— and the break shipped in 0.4.5 without any test noticing. #170 fixed the call sites; this closes the coverage gap so the whole "endpoint wired to a stale handle" class stays caught.Verified the guard is real: reverting
api/app.pyback toeng().metaturns all three tests red with the exactAttributeError; on currentmainthey pass (3 passed).