Claude: label resolved defaults with live model names - #711
Open
katulevskiy wants to merge 1 commit into
Open
katulevskiy wants to merge 1 commit into
katulevskiy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultrow resolved to a newly released model such asclaude-sonnet-5-5, Zeron persisted its Default (recommended) alias label under the concrete model ID. The subsequent named row was discarded as a duplicate, even though Claude had supplied the actual model name.resolvedModelbefore deduplication. Use the named row's live display metadata and description. Claude's descriptions supply versioned headings such asSonnet 5.5; extract that heading whendisplayNameis a short alias, while retaining explicit provider/custom display names.Test plan
42926c80: all three new regressions fail withDefault (recommended)as the actual label.cargo run --locked -p zeron-harness --example claude_models_probe: read-only live discovery against Claude Code 2.1.286 confirmsclaude-sonnet-5-5 => Sonnet 5.5using Claude's supplied metadata, without sending a user prompt/model turn.cargo test --locked -p zeron-harnesscargo test --locked -p zeron-ui --lib normalize_ -- --test-threads=1(2 passed).rustfmt --edition 2024 --check crates/harness/src/claude/catalog.rs crates/harness/tests/claude_models.rs crates/harness/examples/claude_models_probe.rs;git diff --check.cargo clippy --locked -p zeron-harness --all-targets -- -A clippy::non_octal_unix_permissionspasses with no new warnings in changed code. Unmodifiedcargo clippy --locked -p zeron-harness --all-targetsfails on existingPermissions::from_mode(0)calls atcrates/harness/src/skills.rs:874and:911, both present on upstream main.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.