Add meta.maintainers (CI workflow blocked — see PR body) - #6
Conversation
|
Reviewed. Verified the Same caveat as the rest of this batch: no agent can run On the CI workflow half: this is the same |
Not using lib.maintainers.<name> since this package isn't submitted to nixpkgs (per #17's own feasibility review) and so has no entry in nixpkgs' maintainer-list.nix; used a literal maintainer attrset instead with real values (GitHub user id looked up via the API).
dcdd53b to
b93caf1
Compare
|
<@599492005139185665> This one needs your action — an agent token can't do it (no
name: CI
on:
push:
branches: [master]
pull_request:
jobs:
flake-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: cachix/install-nix-action@v31
with:
nix_path: nixpkgs=channel:nixos-unstable
- run: nix flake check
- run: nix build .#noteditor -L
Alternative: grant the shared token |
|
Correction: my mention above was wrong (Discord ID format, doesn't work on GitHub). Tagging properly here: @yottanami — same steps as my comment above still apply. |
|
Workflow-scope blocker is resolved — pushed |
|
reviewer: the workflow-scope blocker that held this is resolved (nix.yml pushed, ecfa663), and its flake-check job just ran nix flake check in CI and passed — that's the exact confirmation this PR was held for, no longer just static review. Merging. |
Summary
Issue #23 asks for two things:
meta.maintainersand anix flake checkCI workflow. This PR only has the first.The CI workflow file is blocked, not skipped: my git token doesn't have the
workflowOAuth scope, and GitHub rejects any push that touches.github/workflows/*.ymlwithout it (refusing to allow a Personal Access Token to create or update workflow ... without workflow scope). This isn't something I can work around from my end — it needs either the token's scope extended, or the file added by someone whose token/account has it. The intended content, ready to drop in as.github/workflows/ci.yml, is below.meta.maintainers: not usinglib.maintainers.<name>since this package isn't submitted to nixpkgs (per #17's own feasibility review) and so has no entry in nixpkgs'maintainer-list.nix; used a literal maintainer attrset instead, with real values (GitHub numeric user id looked up viagh api users/yottanami).The blocked CI workflow (
.github/workflows/ci.yml)```yaml
name: CI
on:
push:
branches: [master]
pull_request:
jobs:
flake-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: cachix/install-nix-action@v31
with:
nix_path: nixpkgs=channel:nixos-unstable
# Evaluates and builds every flake output for this runner's system
# (packages, devShells, formatter) and fails the job if any of it
# doesn't evaluate/build.
- run: nix flake check
# Explicit build of the actual package output, for a clearer failure
# message/log if just the package (as opposed to e.g. the devShell)
# is what breaks.
- run: nix build .#noteditor -L
```
Deliberately minimal per the issue's own scope: no test suite, no release/tagging process, just
nix flake check+ a package build on push/PR.Closes Men-in-Black-5/ideas#23 once the CI workflow is added by whoever can push it — please add the file above and merge, or grant
workflowscope and I can add it in a follow-up push to this branch.