Skip to content

Add meta.maintainers (CI workflow blocked — see PR body) - #6

Merged
yottanami merged 2 commits into
masterfrom
agent/23-ci-maintainers
Aug 27, 2026
Merged

Add meta.maintainers (CI workflow blocked — see PR body)#6
yottanami merged 2 commits into
masterfrom
agent/23-ci-maintainers

Conversation

@yottanami

Copy link
Copy Markdown
Owner

Summary

Issue #23 asks for two things: meta.maintainers and a nix flake check CI workflow. This PR only has the first.

The CI workflow file is blocked, not skipped: my git token doesn't have the workflow OAuth scope, and GitHub rejects any push that touches .github/workflows/*.yml without it (refusing to allow a Personal Access Token to create or update workflow ... without workflow scope). This isn't something I can work around from my end — it needs either the token's scope extended, or the file added by someone whose token/account has it. The intended content, ready to drop in as .github/workflows/ci.yml, is below.

meta.maintainers: not using lib.maintainers.<name> since this package isn't submitted to nixpkgs (per #17's own feasibility review) and so has no entry in nixpkgs' maintainer-list.nix; used a literal maintainer attrset instead, with real values (GitHub numeric user id looked up via gh api users/yottanami).

The blocked CI workflow (.github/workflows/ci.yml)

```yaml
name: CI

on:
push:
branches: [master]
pull_request:

jobs:
flake-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: cachix/install-nix-action@v31
with:
nix_path: nixpkgs=channel:nixos-unstable
# Evaluates and builds every flake output for this runner's system
# (packages, devShells, formatter) and fails the job if any of it
# doesn't evaluate/build.
- run: nix flake check
# Explicit build of the actual package output, for a clearer failure
# message/log if just the package (as opposed to e.g. the devShell)
# is what breaks.
- run: nix build .#noteditor -L
```

Deliberately minimal per the issue's own scope: no test suite, no release/tagging process, just nix flake check + a package build on push/PR.

Closes Men-in-Black-5/ideas#23 once the CI workflow is added by whoever can push it — please add the file above and merge, or grant workflow scope and I can add it in a follow-up push to this branch.

@yottanami

Copy link
Copy Markdown
Owner Author

Reviewed. Verified the meta.maintainers entry directly rather than trusting it: gh api users/yottanami confirms id: 54559, login: yottanami, name: "Behnam Khanbeigi" — all three match the PR's attrset exactly, and the email matches the git commit identity confirmed on PR #5. The inline-attrset shape (name/email/github/githubId, no lib.maintainers.<name> reference) is the correct approach for a package not submitted to nixpkgs, and matches the shape nixpkgs' own generated maintainer entries use. Brackets balance on the edited file.

Same caveat as the rest of this batch: no agent can run nix flake check to confirm the attrset evaluates cleanly, so this needs your confirmation before merge.

On the CI workflow half: this is the same workflow-OAuth-scope block as chord_nebula#1 (pm's already flagging that root cause to you separately, so not re-litigating it here) — the ready-to-apply YAML is in the PR body whenever you're doing the manual paste-in or scope grant.

Not using lib.maintainers.<name> since this package isn't submitted
to nixpkgs (per #17's own feasibility review) and so has no entry in
nixpkgs' maintainer-list.nix; used a literal maintainer attrset
instead with real values (GitHub user id looked up via the API).
@yottanami
yottanami force-pushed the agent/23-ci-maintainers branch from dcdd53b to b93caf1 Compare July 29, 2026 11:59
@yottanami

Copy link
Copy Markdown
Owner Author

<@599492005139185665> This one needs your action — an agent token can't do it (no workflow OAuth scope). Simplest fix:

  1. Go to https://github.com/yottanami/noteditor/edit/master/.github/workflows/ci.yml (creates the file on this PR's branch — or on master directly, either works)
  2. Paste in this content:
name: CI

on:
  push:
    branches: [master]
  pull_request:

jobs:
  flake-check:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: cachix/install-nix-action@v31
        with:
          nix_path: nixpkgs=channel:nixos-unstable
      - run: nix flake check
      - run: nix build .#noteditor -L
  1. Commit it (either as a new commit on this PR's branch, or straight to master if you'd rather merge the rest of this PR separately)

Alternative: grant the shared token workflow scope and an agent can push this directly instead — this same block has come up on chord_nebula#25 too, so it'll keep recurring until one of these two things happens.

@yottanami

Copy link
Copy Markdown
Owner Author

Correction: my mention above was wrong (Discord ID format, doesn't work on GitHub). Tagging properly here: @yottanami — same steps as my comment above still apply.

@yottanami

Copy link
Copy Markdown
Owner Author

Workflow-scope blocker is resolved — pushed .github/workflows/nix.yml (ecfa663). PR now has both pieces the issue asked for.

@yottanami

Copy link
Copy Markdown
Owner Author

reviewer: the workflow-scope blocker that held this is resolved (nix.yml pushed, ecfa663), and its flake-check job just ran nix flake check in CI and passed — that's the exact confirmation this PR was held for, no longer just static review. Merging.

@yottanami
yottanami merged commit 816e1ff into master Aug 27, 2026
2 checks passed
@yottanami
yottanami deleted the agent/23-ci-maintainers branch August 27, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant