Skip to content

MemberData analyzer: analyze test methods declared in records #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bradwilson merged 2 commits into from
Sep 16, 2026
Merged

MemberData analyzer: analyze test methods declared in records #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2c1195
MemberData analyzer: analyze test methods declared in records
meziantou Sep 14, 2026
ff8c4df
Merge remote-tracking branch 'origin/main' into feature/memberdata-re…
bradwilson Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/xunit.analyzers.tests/Analyzers/X1000/X1015_MemberDataShouldReferenceValidMemberTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,36 @@ public class SubClassWithTestData : BaseClassWithTestWithoutData
yield return new object?[] { 42 };
}
}

public record TestRecord {
[Theory]
[{|#4:MemberData("BogusName")|}]
public void MissingLocalDataSource_InRecord_Triggers(int _) { }
}

public record class TestRecordClass {
[Theory]
[{|#5:MemberData("BogusName")|}]
public void MissingLocalDataSource_InRecordClass_Triggers(int _) { }
}

public record struct TestRecordStruct {
[Theory]
[{|#6:MemberData("BogusName")|}]
public void MissingLocalDataSource_InRecordStruct_Triggers(int _) { }
}
""";
var source2 = /* lang=c#-test */ "public class OtherClass { }";
var expected = new[] {
Verify.Diagnostic("xUnit1015").WithLocation(0).WithArguments("BogusName", "TestClass"),
Verify.Diagnostic("xUnit1015").WithLocation(1).WithArguments("BogusName", "TestClass"),
Verify.Diagnostic("xUnit1015").WithLocation(2).WithArguments("BogusName", "OtherClass"),
Verify.Diagnostic("xUnit1015").WithLocation(3).WithArguments("MissingRemoteDataSource_ByNameofAndType_Triggers", "OtherClass"),
Verify.Diagnostic("xUnit1015").WithLocation(4).WithArguments("BogusName", "TestRecord"),
Verify.Diagnostic("xUnit1015").WithLocation(5).WithArguments("BogusName", "TestRecordClass"),
Verify.Diagnostic("xUnit1015").WithLocation(6).WithArguments("BogusName", "TestRecordStruct"),
};

await Verify.VerifyAnalyzer(LanguageVersion.CSharp8, [source1, source2], expected);
await Verify.VerifyAnalyzer(LanguageVersion.CSharp10, [source1, source2], expected);
}
}
6 changes: 3 additions & 3 deletions src/xunit.analyzers/X1000/MemberDataShouldReferenceValidMember.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,11 +290,11 @@ public static (INamedTypeSymbol? TestClass, ITypeSymbol? MemberClass) GetClassTy
memberTypeSymbol = semanticModel.GetTypeInfo(typeSyntax, cancellationToken).Type;
}

var classSyntax = attributeList.FirstAncestorOrSelf<ClassDeclarationSyntax>();
if (classSyntax is null)
var testClassSyntax = attributeList.FirstAncestorOrSelf<TypeDeclarationSyntax>();
if (testClassSyntax is null)
return (null, null);

var testClassTypeSymbol = semanticModel.GetDeclaredSymbol(classSyntax, cancellationToken);
var testClassTypeSymbol = semanticModel.GetDeclaredSymbol(testClassSyntax, cancellationToken);
return (testClassTypeSymbol, memberTypeSymbol ?? testClassTypeSymbol);
}

Expand Down