[plugin.audio.classicalradio] v1.0.0 by edouardduliege · Pull Request #4837 · xbmc/repo-plugins

edouardduliege · 2026-09-25T20:32:07Z

Initial submission of the ClassicalRadio community add-on for Kodi.

The add-on provides linear ClassicalRadio playback for AudioAddict account holders, including:

channel browsing
Popular and New views
favourites synchronisation
Premium stream quality selection
bounded stream-server probing and conservative fallback
dynamic Now Playing metadata
secure session reuse
English and French localisation

The add-on targets Linux and uses kernel-managed playback-state locking with flock.

This is an unofficial community add-on and is not affiliated with, endorsed by, or supported by ClassicalRadio or AudioAddict.

The add-on uses original community artwork and does not redistribute the official ClassicalRadio logo.

coderabbitai · 2026-09-25T20:32:16Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c999b7c5-658f-4b67-ac46-7b35f49e664d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

greptile-apps · 2026-09-25T20:36:09Z

Confidence Score: 4/5

[Medium risk] New Kodi audio plugin for ClassicalRadio streaming.

The PR is not ready to merge while the Favorites view cannot reliably remove favorites.

Findings

Favorites show the wrong action ▶
Playlist URLs can reach private services ▶
Redirects can expose session keys ▶
Redirected streams may lose metadata ▶
Restarts can receive stale metadata ▶

Summary

Adds a Linux-targeted ClassicalRadio Kodi add-on with account authentication, channel and favorites browsing, Premium stream selection, and a background Now Playing service.

Favorites removal is broken in the Favorites view when channel IDs are numeric.
Stream and authenticated API redirects need tighter destination handling; playback identity and redirected-stream metadata need attention.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Kodi directory plugin] --> B[AudioAddict client]
  B --> C[Channels and favorites API]
  B --> D[PLS playlist]
  D --> E[Stream probe]
  E --> F[Kodi playback]
  A --> G[Playback state]
  G --> H[Metadata service]
  H --> B
  H --> F

_{Reviews (1) · Last reviewed commit: "[plugin.audio.classicalradio] v1.0.0"}

greptile-apps · 2026-09-25T20:36:13Z

+            line = raw_line.strip()
+            if line.lower().startswith("file") and "=" in line:
+                candidate = line.split("=", 1)[1].strip()
+                if candidate.startswith("http"):


Playlist URLs can reach private services If a remote playlist supplies a loopback or private-network URL, or redirects to one, opening the channel makes the Kodi device send a GET to that destination. Checking only that the entry starts with http does not restrict where the probe goes. Validate destinations, including redirects, before requesting or playing them. How this was verified: Playlist entries flow directly into a redirect-following GET without a host or address check.

greptile-apps · 2026-09-25T20:36:13Z

+        )
+
+        try:
+            response = self.http.get(


Redirects can expose session keys If the API redirects an authenticated request to another origin, the request follows that redirect with its custom X-Session-Key header, exposing the user's session key to the destination. Restrict authenticated redirects to the API origin or remove the header before following them. How this was verified: The authenticated request sets X-Session-Key and follows redirects without checking the destination origin.

greptile-apps · 2026-09-25T20:36:13Z

+
+            if playing_file != expected_stream:
+                xbmc.log(
+                    "[plugin.audio.classicalradio] playing stream mismatch in service loop: "
+                    f"getPlayingFile={safe_url_for_log(playing_file)!r}, "
+                f"state_stream_url={safe_url_for_log(expected_stream)!r}",
+                    xbmc.LOGDEBUG,
+                )
+                continue


Redirected streams may lose metadata If Kodi reports a redirected or normalized playing URL, it will differ from the original playlist URL saved in playback state. This exact comparison then skips every Now Playing update. Test redirected streams against Kodi's reported URL and use a playback check that accommodates the difference.

greptile-apps · 2026-09-25T20:36:13Z

+    if (
+        latest_state.get("mode") != "linear"
+        or latest_state.get("channel_key") != channel
+        or latest_state.get("stream_url") != state.get("stream_url")
+    ):
+        return


Restarts can receive stale metadata If a channel restarts with the same stream URL while a metadata lookup is in progress, this check treats the new playback as the old one. The earlier lookup can then update the new playing item and its saved track ID. Give each playback a unique identifier and check it before applying the update.

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

romanvm · 2026-09-26T16:41:16Z

PUBLICATION_CHECKLIST.md here as well.

edouardduliege · 2026-09-26T17:41:28Z

PUBLICATION_CHECKLIST.md has been removed

[plugin.audio.classicalradio] v1.0.0

0d2ccad

greptile-apps Bot reviewed Sep 25, 2026

View reviewed changes

Update plugin.audio.classicalradio/default.py

b147005

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

romanvm added the waiting for developer to respond label Sep 26, 2026

[plugin.audio.classicalradio] Remove publication checklist from package

7d6d788

Navigation Menu

[plugin.audio.classicalradio] v1.0.0 - #4837

[plugin.audio.classicalradio] v1.0.0#4837
edouardduliege wants to merge 3 commits into
xbmc:omegafrom
edouardduliege:plugin.audio.classicalradio

edouardduliege commented Sep 25, 2026

Uh oh!

coderabbitai Bot commented Sep 25, 2026 •

edited

Loading

Review skipped

Uh oh!

greptile-apps Bot commented Sep 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

greptile-apps Bot Sep 25, 2026

Uh oh!

greptile-apps Bot Sep 25, 2026

Uh oh!

greptile-apps Bot Sep 25, 2026

Uh oh!

greptile-apps Bot Sep 25, 2026

Uh oh!

romanvm commented Sep 26, 2026

Uh oh!

edouardduliege commented Sep 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

edouardduliege commented Sep 25, 2026

Uh oh!

coderabbitai Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

greptile-apps Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Findings

Uh oh!

Uh oh!

greptile-apps Bot Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

romanvm commented Sep 26, 2026

Uh oh!

edouardduliege commented Sep 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Sep 25, 2026 •

edited

Loading

greptile-apps Bot commented Sep 25, 2026 •

edited

Loading