Skip to content

Add CancelWhenDeferred, like FailWhenDeferred. - #715

Open
barnson wants to merge 1 commit into
mainfrom
bob/CancelWhenDeferred
Open

Add CancelWhenDeferred, like FailWhenDeferred.#715
barnson wants to merge 1 commit into
mainfrom
bob/CancelWhenDeferred

Conversation

@barnson

@barnson barnson commented Aug 2, 2026

Copy link
Copy Markdown
Member

Useful for integration testing packages.

Useful for integration testing packages.
@barnson
barnson requested a review from robmen August 2, 2026 02:55
@barnson barnson self-assigned this Aug 2, 2026
WixAssert.CompareLineByLine(
[
"Binary:Wix4UtilCA_X64\t[Binary data]",
"CustomAction:Wix4CancelWhenDeferred_X64\t1025\tWix4UtilCA_X64\tWixCancelWhenDeferred\t",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wix4CancelWhenDeferred? Not Wix7?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh. I hate whoever came up with this wacky idea...and all because of stupid merge modules. Well, it would be Wix8 right? But we still use Wix4 for the Binary id. Maybe we should be rev'ing that every release? Or do we need to change it if we add something? But not change something? 🤕

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, the Binary id gets a modularization guid, so it's "safe."

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just the table names that need to be unique.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have doc that uses BinaryRef="Wix4UtilCA_$(sys.BUILDARCHSHORT)" so we shouldn't change it unnecessarily. If I had a time machine, I'd have done this differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants