Pin bs-highlighter for now

[jakearchibald]

The latest bs-highlighter broke the build. From Claude:

The 3.x line re-escapes < as < in highlighted IDL blocks; Wattsi re-parses the highlighter's output as IDL and chokes on Promise<undefined>. So the build broke.

@tabatkins can you give me more details around the change? It might make more sense to just change Wattsi.

[tabatkins]

As I said to Sam in tabatkins/highlighter#38 (comment), I've altered the defaults to make more sense in general, so you have to reapply those two settings yourself. (Previously, the "server" script was just something I threw together solely for wattsi itself; while revisiting the code I fixed it up to its own command and made sure it worked decently in general.)

[tabatkins]

(I only use escape HTML in the output when spitting out HTML text, as is necessary for it to be valid. If it's JSON it shouldn't be doing any escaping. But I also have an option to unescape the input json-HTML when it (incorrectly) contains escapes in its text, I think because that's how wattsi happened to hand it to me.)

Edit: Confirmed in my test file that my escaping works as expected; the issue is indeed that wattsi is feeding it (incorrectly) escaped text but the unescape param is no longer passed, so it just spits that back out.

[tabatkins]

Looks like the place to update is in https://github.com/whatwg/wattsi/blob/8b5e69511314449379109ce44df0109cf3d01f9d/src/wattsi.pas#L2461

[jakearchibald]

Cheers @tabatkins. I'll look at a proper fix.

[tabatkins]

If it would be easier, I could probably make the bs-highlighter-server command take defaults, so you'd just need to update the build.sh here rather than updating wattsi. (But if making the edit isn't troublesome, it's an easy fix.)

[tabatkins]

Oh btw Jake, Claude got the problem exactly backwards. ^_^ It's bs-highlighter that's parsing as WebIDL and choking on the Promise<undefined> from the input. As a result it doesn't even emit any output; it returns a 400 response with the IDL SyntaxError instead.

[jakearchibald]

Haha yes, I've just figured that out too haha

[jakearchibald]

PR whatwg/wattsi#168