md5sum.h: fix tautological comparison warning on 32-bit systems - #148
Merged
skal65535 merged 1 commit intoAug 10, 2026
Merged
Conversation
Explicitly cast data.size() to uint64_t in assert to prevent -Wtautological-constant-out-of-range-compare warnings on 32-bit builds.
skal65535
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On 32-bit architectures where
std::string::size_type(size_t) is 32-bit,data.size() < (1ull << 32)is tautologically true and causes Clang/GCC to emit-Wtautological-constant-out-of-range-compareunder-Werror.Casting
data.size()touint64_tpreserves the 4GB bounds assertion on 64-bit systems while silencing the compiler warning on 32-bit systems.