Skip to content

Restrict scale's values of dequantizeLinear and quantizeLinear to be positive and nonzero - #906

Merged
fdwr merged 7 commits into
webmachinelearning:mainfrom
BruceDai:positive_scale_qdq
Mar 10, 2026
Merged

Restrict scale's values of dequantizeLinear and quantizeLinear to be positive and nonzero#906
fdwr merged 7 commits into
webmachinelearning:mainfrom
BruceDai:positive_scale_qdq

Conversation

@BruceDai

@BruceDai BruceDai commented Nov 25, 2025 •
edited by pr-preview Bot
Loading

Copy link
Copy Markdown
Contributor

This is a Spec change PR for #879 where we're discussing about the lack of widespread support for the current negative scale of dequantizeLinear and quantizeLinear across all backend.

@fdwr @reillyeon @huningxin PTAL, thanks!

Preview | Diff

philloooo
philloooo reviewed Nov 25, 2025
View reviewed changes
Comment thread index.bs Outdated
fdwr
fdwr reviewed Nov 26, 2025
View reviewed changes

@fdwr fdwr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Comment thread index.bs Outdated
Comment thread index.bs Outdated
fdwr
fdwr approved these changes Nov 27, 2025
View reviewed changes

@fdwr fdwr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM after 2 comments.

Comment thread index.bs Outdated
Comment thread index.bs Outdated
@BruceDai BruceDai changed the title Restrict scale of dequantizeLinear and quantizeLinear to be positive Restrict scale's values of dequantizeLinear and quantizeLinear to be positive and nonzero Jan 16, 2026
huningxin
huningxin approved these changes Jan 16, 2026
View reviewed changes

@huningxin huningxin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fdwr
fdwr approved these changes Jan 16, 2026
View reviewed changes

@fdwr fdwr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
(awaiting Phillis and Reilly before merging?)

reillyeon
reillyeon suggested changes Jan 20, 2026
View reviewed changes
Comment thread index.bs Outdated
fdwr
fdwr reviewed Jan 23, 2026
View reviewed changes

@fdwr fdwr left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM (just normalized wording across the two regions).

Comment thread index.bs Outdated
Comment thread index.bs Outdated
@BruceDai

BruceDai commented Jan 23, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @fdwr for your update👍

@fdwr

fdwr commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

@reillyeon - look good to you now?

@fdwr
fdwr merged commit a4a7eb6 into webmachinelearning:main Mar 10, 2026
2 checks passed
github-actions Bot added a commit that referenced this pull request Mar 10, 2026
@BruceDai @github-actions
Restrict scale's values of dequantizeLinear and quantizeLinear to be …
43202a7 
…positive and nonzero (#906)

SHA: a4a7eb6
Reason: push, by fdwr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fdwr fdwr fdwr approved these changes
@huningxin huningxin huningxin approved these changes
+2 more reviewers
@philloooo philloooo philloooo left review comments
@reillyeon reillyeon reillyeon approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BruceDai @fdwr @reillyeon @huningxin @philloooo