Fixing scenario where false unavailable items are show on ReviewBlock#184
Open
wender wants to merge 2 commits into
Open
Fixing scenario where false unavailable items are show on ReviewBlock#184wender wants to merge 2 commits into
wender wants to merge 2 commits into
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
nicholas-maestrello
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes seller resolution in
ReviewBlockduring refId validation (Copy/Paste and Upload flows).Problem: After
skuFromRefIds, seller data was taken frommappedRefId, which was only filled for items found in the autocomplete restriction check. When an item was missing from that map, the UI got:rowData.sellers→ no seller dropdown even when the API returned multiple sellerssellerWithStock→ false "Restricted Item" even when stock existed on another sellerThis showed up in stores with multiple sellers per SKU (e.g. default seller
"1"without stock + marketplace seller"cromosolsc1"with stock on sales channel4).Solution:
skuFromRefIdsAPI response (refIdApiMap)availableorpartiallyAvailablestockvtexSku,unitMultiplier, andavailableQuantitysetRestriction/checkRestrictionautocomplete logic that fed the brokenmappedRefIdflowHow to test it?
Workspace
Example: RefId
1006→ SKU12250, sellers"1"(withoutStock) and"cromosolsc1"(available).1006,1).cromosolsc1/CROMOSOL)Optional: In devtools, confirm
skuFromRefIdsreturns multiple sellers and the review row hassellers.length > 1and a resolvedseller.Screenshots
Before:

After:
