Skip to content

fix: replace retiring openai model defaults - #257

Open
Anandb71 wants to merge 1 commit into
vstorm-co:mainfrom
Anandb71:arbor/retire-openai-defaults
Open

Anandb71 wants to merge 1 commit into
vstorm-co:mainfrom
Anandb71:arbor/retire-openai-defaults

Conversation

@Anandb71

@Anandb71 Anandb71 commented Nov 9, 2026

Copy link
Copy Markdown

Summary

openai shuts down gpt-4.1 and gpt-4o-mini on jan 14, 2027 (deprecations). the cli openai default, the acp key fallback and the automatic fork vote model still use them, so this moves all three to openai:gpt-6-luna, the listed replacement.

Changes

  • cli default and acp fallback: openai:gpt-4.1 to openai:gpt-6-luna, plus the acp default table in the docs
  • fork vote model: openai:gpt-4o-mini to openai:gpt-6-luna
  • cli default only: openai_reasoning_effort="none" so its sampling settings (including headless temperature=0.0) still work. acp and the judges go through responses, so they need no change. explicit cli reasoning settings still win

Testing

  • New tests added for any new functionality
  • All tests pass locally: make test (full coverage run: 2843 passed, 100% coverage, one intermittent tui cost render test failed and passed on immediate isolated rerun)
  • Linting passes (ruff check and format)
  • Type checking passes (mypy and pyright, zero errors on touched files)
  • Security scan passes (bandit, no medium or high)
  • Full check suite passes: make all (not run as one command, pieces above)

request params checked with networking blocked. no live model calls.

Related Issues

none

Notes for Reviewers

the flaky test is tests/test_tui_forking.py::TestForkTabsCostRender::test_cost_renders_when_set_same_tick_as_statuses, unrelated to this diff.

Copilot AI balanced review requested due to automatic review settings November 9, 2026 17:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants