feat(httpx): retry 429 and 503 with Retry-After backoff#227
Open
TBX3D wants to merge 1 commit into
Open
Conversation
pr summary4 files changed (+347 -22)
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
=======================================
Coverage ? 53.43%
=======================================
Files ? 81
Lines ? 6904
Branches ? 0
=======================================
Hits ? 3689
Misses ? 2945
Partials ? 270 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
25f6cac to
14a34ee
Compare
the shared transport paced outbound requests but ignored a server asking it to slow down, so a 429 or 503 came straight back as a failed probe. back off and retry both through the one chokepoint every scanner shares, honoring Retry-After (delta-seconds or http-date) and falling back to capped exponential backoff. gated behind -max-retries (default 2, 0 disables). bodyless GETs and GetBody-backed requests replay safely; anything else is returned as-is.
14a34ee to
f4a8cf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the shared transport paced outbound requests but ignored a server
asking it to slow down, so a 429 or 503 came straight back as a failed
probe. back off and retry both through the one chokepoint every scanner
shares, honoring Retry-After (delta-seconds or http-date) and falling
back to capped exponential backoff.
gated behind -max-retries (default 2, 0 disables). bodyless GETs and
GetBody-backed requests replay safely; anything else is returned as-is.