Repository navigation
Reorganize the module into folders with v.mod subdirs - #7
Merged
Merged
Conversation
Member
|
You can use AI fit's confirmed, you can merge the PR your The kdl library itself is pretty small, so the main focus going forward is on stability and releasing it to the vpm site |
Contributor
Author
I don't have rights to do it |
Member
Try again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Jengro777 sorry about that. Since V dropped the virtual
src/directory, I've gotten into the habit of keeping modules flat, and I overdid it here. Following your comment, this brings a hierarchy back:The folders are listed as
subdirsinv.mod, the mechanism that replacedsrc/(vlang/v@5518bfc). Every file stays inmodule kdl, so the API is unchanged, and the tests now only use the public API. The source files are moved as they are, with no code changes.One caveat:
v docdoesn't followsubdirsyet, so symbols from the subfolders are missing from the generated docs. I can send a fix upstream if you're OK with this layout.