Repository navigation
Add ci and fix tests v2 - #5
Merged
Merged
Conversation
- ci.yml: run v test . on push/PR to main, pin V 0.5.2, use checkout@v7 with least-privilege permissions, add concurrency and timeout - roundtrip_fuzz_test: migrate to current rand API (new_default, int_in_range) and match document sum-type variants directly
The 0.5.2 release tag fails to compile itself on ubuntu-latest (vlib os C.open declaration conflict). Pin a known-good master commit (aaaf0c7) instead, which builds and passes the full suite.
There was a problem hiding this comment.
Pull request overview
Adds GitHub Actions CI and updates the round-trip fuzz test for deterministic, instance-based randomness and current document types.
Changes:
- Adds Ubuntu CI running the full V test suite.
- Makes fuzz generation reproducible with a seeded PRNG.
- Updates sum-type matching to use document variants.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Adds the CI workflow and pinned V compiler setup. |
tests/roundtrip_fuzz_test.v |
Updates deterministic fuzzing and type matching. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| import kdl | ||
| import rand | ||
| import rand.seed | ||
| import document |
| assert_values_equivalent(a.value, b.value, iter, ndx, eidx) | ||
| } else { | ||
| assert false, 'iter ${iter} node[${ndx}] entry[${eidx}]: type mismatch Argument vs ${typeof(b)}' | ||
| assert false, 'iter ${iter} node[${ndx}] entry[${eidx}]: type mismatch Argument' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.