fix: csp headers for index pages#2593
Open
mburri wants to merge 2 commits into
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hupf
approved these changes
Jul 1, 2026
hupf
left a comment
hupf
left a comment
Contributor
There was a problem hiding this comment.
Looks good. As the Next.js + i18n combo is causing this behavior, it may be useful to check the header in an E2E test, to catch when the behavior changes again...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No CSP Header was set for index pages, e.g. https://visualize.admin.ch/en
Pages with more than one path segment included the correct headers: https://visualize.admin.ch/en/imprint
The cause was that the matcher in middleware.ts was is recompiled for i18n routing during the build. The newly generated matcher did only match routes with at least two path segments, e.g.
/en/imprint, but not/enitself.It is not known to me whether upgrading next.js would fix this too.