Conversation
Co-authored-by: Copilot <copilot@github.com>
Signed-off-by: Ludea <ludovicw35@hotmail.com>
Ludea
changed the title
Legend-Master
left a comment
Legend-Master
left a comment
Collaborator
There was a problem hiding this comment.
We will probably need an example that uses the vendored feature to show case how to use it and a section in the crate docs and readme for that
Legend-Master
left a comment
Legend-Master
left a comment
Collaborator
There was a problem hiding this comment.
Have you tested this yet?
| .setup(|app| { | ||
| dbg!(app.get_webview_window("main").unwrap().inner_size()).unwrap(); | ||
| // embed verso webview into app | ||
| tauri_runtime_verso::vendored::create_embedded_versoview().unwrap(); |
Collaborator
There was a problem hiding this comment.
Not sure I get this, isn't this just running the versoview? Don't we need to connect our app with it? And 2 different event loops can't work together, versoview will still need to be on another process for now
Signed-off-by: Ludea <ludovicw35@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.