Repository navigation
Keep int32 class fields beside Buffer.from over an ArrayBuffer range - #2070
Merged
Merged
Conversation
Buffer.from(arrayBuffer, byteOffset[, length]) lowers to buffer.poolFromDynRange with its operands as checked values. The int32 slot analysis treats any runtime helper with a checked-value argument as a possible store into a live class instance unless the helper is listed as read-only, so one such call dropped every int32 class field fact in the program (tsc-ts's scanner makes one). buffer.poolFromDynRange and buffer.poolFromDynOffset read their operands (the ArrayBuffer's view after Node's offset and length conversions, or a copy of a string's, array-like's or typed array's values) and store into no class instance, so they join DYN_READ_ONLY.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buffer.from(arrayBuffer, byteOffset, length)passes its operands as checked values, and the int32 slot analysis treated that helper as a possible store into any class field, so one such call dropped every int32 class field in the program.