Repository navigation
Convert checked-dynamic expected errors in assert.throws and assert.match - #2066
Merged
Merged
Conversation
…atch An expected regex or string read from a JavaScript object literal's field is a checked-dynamic value while its checker type is RegExp or string. assert.throws chose its regex comparison from the checker type and passed the value unconverted, an internal compiler error, and assert.match and the expected-object form refused it. Such a value now converts to the regex or string its type names.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assert.throws, and was refused byassert.matchand the expected-object form. It now converts to the regex or string its type names.