Repository navigation
Conversation
Contributor
|
@jlucaso1 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
const { value } = events["a.b"]was refused with SC1031 wheneventswasany, although assigning the RHS to a temporary already worked. Accept string-literal element reads indestrSpellingOf, using V8's dot spelling and decoded key text. Existing checked-dynamic destructuring evaluates the source once and performs the binding reads.Source spellings containing NUL use an existing JSON-builder operation with an explicit byte count. Other expressions retain their existing error helper. The corpus covers escaped keys, renames, defaults, rest, nesting, ordered getters, lazy defaults, single RHS evaluation, assignment through the shared helper, and nullish error spelling. A diagnostic fixture pins the remaining refusals for calculated RHS keys, optional element reads and template literals.
Fixes #1677. #1503 supplies the identifier/numeric RHS path; #1552 concerns computed keys in the binding pattern.
Validation at
7aff706f6, compared witheca0cab8a:@oxidezap/baileyrs0.3.11makeEventBufferAPI using fictitious data. It printsnotify 1 sample-1, byte-identical to Node, with empty stderr. The base refuses it with SC1031. This evidence covers the event-map boundary, not whole-library native compatibility or a WhatsApp session.A bounded local full-suite attempt also exposed the existing library-mode K10 K5/K7 LeakSanitizer failure: the untouched base and candidate both report the same 59-byte leak and identical stdout. The Vercel Sandbox preflight could not access the configured project. These local environment limits remain recorded; the complete fork CI and zero-cost gate pass.
Upstream CI integration: the
coverage.test.tsexplain-dynamic snapshot currently fails with the same helper order/source-position difference on untouched upstream main and this PR. The Vercel deployment check requests external authorization. These are not reported as passing checks.The same untouched-main CI run also reports
contract-int32-arrays.ts,contract-int32-escapes.ts, and6583-emitter-untyped-surface.tsfailures, which are present in this PR CI as well. The issue patch remains unchanged.Upstream CI has now completed on
7aff706f6: 29 jobs passed, 22 test jobs failed as documented above, the aggregate test gate failed, and eight jobs were skipped. The final pending IR-parity and sanitized jobs passed. Agent/security reviews and Socket checks passed; Vercel deployment authorization remains external. No tests or snapshots were changed to suppress these failures.