Skip to content

Open Envoy Fixes - #21

Merged
rakesh-snippyly merged 2 commits into
mainfrom
open-envoy-fixes
Dec 17, 2025
Merged

rakesh-snippyly merged 2 commits into
mainfrom
open-envoy-fixes

Conversation

@yoen-velt

@yoen-velt yoen-velt commented Dec 16, 2025 •

Copy link
Copy Markdown
Contributor

Pull Request

Description

Type of Change

  • New demo application
  • Bug fix
  • Feature enhancement
  • Documentation update
  • Infrastructure/tooling change
  • Other (please describe):

Monorepo Structure Checklist

If adding a new demo, ensure you've followed the 5-level structure:

  • Placed in correct path: apps/<framework>/<document>/<type>/<implementation>/<library-or-solution>/<demo>/
  • Updated package.json with scoped name: @apps/<framework>-<document>-<library-or-solution>-<demo>
  • Created comprehensive README.md in the demo directory
  • Verified build passes: pnpm --filter <package-name> build
  • Verified dev server runs: pnpm --filter <package-name> dev

Deployment Checklist

If this demo should be deployed:

  • Added/updated Vercel project configuration
  • Updated GitHub Actions workflows (if applicable)
  • Verified deployment paths in CI/CD configs

Testing

  • Tested locally with pnpm -w install && pnpm -w build
  • Verified all affected apps still build
  • Tested dev servers for affected apps

Documentation

  • Updated relevant documentation (if needed)
  • Added demo to master-sample-app (if applicable)
  • Updated deployment docs (if applicable)

Related Issues

Screenshots/Videos

Additional Context


For Reviewers

Demo Location

Path: apps/<framework>/<document>/<type>/<implementation>/<library-or-solution>/<demo>/

Package name: @apps/<...>

How to Test

# Install dependencies
pnpm -w install

# Run the specific demo
pnpm --filter @apps/<package-name> dev

# Build the specific demo
pnpm --filter @apps/<package-name> build

Structure Verification

The demo follows the 5-level hierarchy:

  1. Framework:
  2. Document:
  3. Type:
  4. Implementation:
  5. Library/Solution:
  6. Demo:

Documentation: See README_MONOREPO.md and docs/structure.md for more details on the monorepo structure.


Note

Modularizes the document UI into reusable components, externalizes data/icons, integrates Velt notifications in the sidebar with unread counts, and updates the comments sidebar behavior.

  • UI/Structure (Open Envoy demo):
    • Extracts Avatar, DueBadge, StatusBadge, SummaryCards, JobsTable, Pagination, and CommentsSidebar into dedicated components.
    • Moves inline SVGs to shared components/document/icons.tsx and reuses across views.
    • Refactors document-canvas.tsx to compose new components and re-export types.
    • JobsTable uses VeltCommentBubble; row click opens CommentsSidebar.
  • Data & Types:
    • Externalizes mock data to components/document/jobs-data.ts and interfaces to components/document/types.ts.
  • Notifications:
    • Sidebar switches from embedded VeltNotificationsPanel to VeltNotificationsTool with useNotificationUtils and useUnreadNotificationsCount; clickable Notifications row shows panel and unread badge.
    • Adds VeltNotificationsToolWireframe customization and registers it in ui-customization/index.tsx; removes notifications tool from VeltTools.
  • Comments/Collaboration:
    • Sets pageMode=true on VeltCommentsSidebar in VeltCollaboration.

Written by Cursor Bugbot for commit 7f7b05e. This will update automatically on new commits. Configure here.

@yoen-velt yoen-velt self-assigned this Dec 16, 2025
@vercel

vercel Bot commented Dec 16, 2025 •

Copy link
Copy Markdown

setIsNotificationsPanelOpen(!isNotificationsPanelOpen);
const handleNotificationsClick = () => {
notificationUtils?.openNotificationsPanel();
};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing VeltNotificationsPanel breaks notification display

The VeltNotificationsPanel component was completely removed from the codebase, but handleNotificationsClick still calls notificationUtils?.openNotificationsPanel(). This method expects a VeltNotificationsPanel component to be rendered somewhere in the app for it to actually display notifications. Without the panel component, clicking the notifications button won't show anything - the notification functionality is effectively broken. The VeltNotificationsTool only renders the unread count badge, not the actual panel UI.

Fix in Cursor Fix in Web

style={{ fontFamily: 'Inter, sans-serif' }}
>
{notificationCount}
</span>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Notification badge displays when count is zero

The notification badge is always rendered regardless of the count value. When notificationCount is 0 (from unreadCount?.forYou ?? 0), a red badge with "0" will be displayed. The original NavItem component correctly used {badge && (...)} to conditionally hide the badge when falsy, but this new custom button implementation renders the badge unconditionally. Notification badges typically hide when the count is zero.

Fix in Cursor Fix in Web

{/* VeltNotificationsTool positioned at end of row for panel placement */}
<div className="absolute right-0 top-0 h-full flex items-center opacity-0 pointer-events-none">
<VeltNotificationsTool />
</div>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: VeltNotificationsTool configuration props lost during refactoring

The VeltNotificationsTool was moved from VeltTools.tsx to the sidebar but lost all its configuration props. The original had settings={true}, shadowDom={false}, and a tabConfig object configuring tab names and visibility. The new hidden VeltNotificationsTool has no props, which may cause the notifications panel to behave differently: potentially missing the settings button, having shadow DOM enabled affecting styling, and showing default tab configuration instead of the customized one.

Additional Locations (1)

Fix in Cursor Fix in Web

@rakesh-snippyly
rakesh-snippyly merged commit 5a5b9a5 into main Dec 17, 2025
17 of 18 checks passed

This branch was successfully deployed

15 active deployments
Preview – sample-apps-ag-grid-multiple-tools — 7f7b05ee Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-ag-grid-comment-aggregation — 7f7b05ee Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-tiptap-comments-demo — 7f7b05ee Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-tanstack-comment-aggregation — 7f7b05ee Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-ag-grid-single-tool — 7f7b05ee Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-tanstack-single-tool — 7f7b05ee Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-tanstack-multiple-tools — 7f7b05ee Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-reactflow-demo — 7f7b05ee Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-codemirror-crdt-demo — 7f7b05ee Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-lexical-comments-demo — 7f7b05ee Deployed Dec 16, 2025 by vercel[bot]
Preview – master-sample-app — 7f7b05ee Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-tiptap-crdt-demo — 7f7b05ee Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-dashboard-demo — 7f7b05ee Deployed Dec 16, 2025 by vercel[bot]
Preview – open-envoy-demo — 7f7b05ee Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-slatejs-comments-demo — 7f7b05ee Deployed Dec 16, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants