Repository navigation
Open Envoy Fixes - #21
Conversation
| setIsNotificationsPanelOpen(!isNotificationsPanelOpen); | ||
| const handleNotificationsClick = () => { | ||
| notificationUtils?.openNotificationsPanel(); | ||
| }; |
There was a problem hiding this comment.
Bug: Missing VeltNotificationsPanel breaks notification display
The VeltNotificationsPanel component was completely removed from the codebase, but handleNotificationsClick still calls notificationUtils?.openNotificationsPanel(). This method expects a VeltNotificationsPanel component to be rendered somewhere in the app for it to actually display notifications. Without the panel component, clicking the notifications button won't show anything - the notification functionality is effectively broken. The VeltNotificationsTool only renders the unread count badge, not the actual panel UI.
| style={{ fontFamily: 'Inter, sans-serif' }} | ||
| > | ||
| {notificationCount} | ||
| </span> |
There was a problem hiding this comment.
Bug: Notification badge displays when count is zero
The notification badge is always rendered regardless of the count value. When notificationCount is 0 (from unreadCount?.forYou ?? 0), a red badge with "0" will be displayed. The original NavItem component correctly used {badge && (...)} to conditionally hide the badge when falsy, but this new custom button implementation renders the badge unconditionally. Notification badges typically hide when the count is zero.
770dfd1 to
7f7b05e
Compare
| {/* VeltNotificationsTool positioned at end of row for panel placement */} | ||
| <div className="absolute right-0 top-0 h-full flex items-center opacity-0 pointer-events-none"> | ||
| <VeltNotificationsTool /> | ||
| </div> |
There was a problem hiding this comment.
Bug: VeltNotificationsTool configuration props lost during refactoring
The VeltNotificationsTool was moved from VeltTools.tsx to the sidebar but lost all its configuration props. The original had settings={true}, shadowDom={false}, and a tabConfig object configuring tab names and visibility. The new hidden VeltNotificationsTool has no props, which may cause the notifications panel to behave differently: potentially missing the settings button, having shadow DOM enabled affecting styling, and showing default tab configuration instead of the customized one.
Pull Request
Description
Type of Change
Monorepo Structure Checklist
If adding a new demo, ensure you've followed the 5-level structure:
apps/<framework>/<document>/<type>/<implementation>/<library-or-solution>/<demo>/package.jsonwith scoped name:@apps/<framework>-<document>-<library-or-solution>-<demo>pnpm --filter <package-name> buildpnpm --filter <package-name> devDeployment Checklist
If this demo should be deployed:
Testing
pnpm -w install && pnpm -w buildDocumentation
master-sample-app(if applicable)Related Issues
Screenshots/Videos
Additional Context
For Reviewers
Demo Location
Path:
apps/<framework>/<document>/<type>/<implementation>/<library-or-solution>/<demo>/Package name:
@apps/<...>How to Test
Structure Verification
The demo follows the 5-level hierarchy:
Documentation: See README_MONOREPO.md and docs/structure.md for more details on the monorepo structure.
Note
Modularizes the document UI into reusable components, externalizes data/icons, integrates Velt notifications in the sidebar with unread counts, and updates the comments sidebar behavior.
Avatar,DueBadge,StatusBadge,SummaryCards,JobsTable,Pagination, andCommentsSidebarinto dedicated components.components/document/icons.tsxand reuses across views.document-canvas.tsxto compose new components and re-exporttypes.JobsTableusesVeltCommentBubble; row click opensCommentsSidebar.components/document/jobs-data.tsand interfaces tocomponents/document/types.ts.VeltNotificationsPaneltoVeltNotificationsToolwithuseNotificationUtilsanduseUnreadNotificationsCount; clickable Notifications row shows panel and unread badge.VeltNotificationsToolWireframecustomization and registers it inui-customization/index.tsx; removes notifications tool fromVeltTools.pageMode=trueonVeltCommentsSidebarinVeltCollaboration.Written by Cursor Bugbot for commit 7f7b05e. This will update automatically on new commits. Configure here.