Skip to content

Add missing @veltdev/types dependency to open-envoy-demo - #20

Merged
yoen-velt merged 2 commits into
mainfrom
fix/add-veltdev-types
Dec 16, 2025
Merged

yoen-velt merged 2 commits into
mainfrom
fix/add-veltdev-types

Conversation

@yoen-velt

@yoen-velt yoen-velt commented Dec 16, 2025 •

Copy link
Copy Markdown
Contributor

🤖 Generated with Claude Code

Pull Request

Description

Type of Change

  • New demo application
  • Bug fix
  • Feature enhancement
  • Documentation update
  • Infrastructure/tooling change
  • Other (please describe):

Monorepo Structure Checklist

If adding a new demo, ensure you've followed the 5-level structure:

  • Placed in correct path: apps/<framework>/<document>/<type>/<implementation>/<library-or-solution>/<demo>/
  • Updated package.json with scoped name: @apps/<framework>-<document>-<library-or-solution>-<demo>
  • Created comprehensive README.md in the demo directory
  • Verified build passes: pnpm --filter <package-name> build
  • Verified dev server runs: pnpm --filter <package-name> dev

Deployment Checklist

If this demo should be deployed:

  • Added/updated Vercel project configuration
  • Updated GitHub Actions workflows (if applicable)
  • Verified deployment paths in CI/CD configs

Testing

  • Tested locally with pnpm -w install && pnpm -w build
  • Verified all affected apps still build
  • Tested dev servers for affected apps

Documentation

  • Updated relevant documentation (if needed)
  • Added demo to master-sample-app (if applicable)
  • Updated deployment docs (if applicable)

Related Issues

Screenshots/Videos

Additional Context


For Reviewers

Demo Location

Path: apps/<framework>/<document>/<type>/<implementation>/<library-or-solution>/<demo>/

Package name: @apps/<...>

How to Test

# Install dependencies
pnpm -w install

# Run the specific demo
pnpm --filter @apps/<package-name> dev

# Build the specific demo
pnpm --filter @apps/<package-name> build

Structure Verification

The demo follows the 5-level hierarchy:

  1. Framework:
  2. Document:
  3. Type:
  4. Implementation:
  5. Library/Solution:
  6. Demo:

Documentation: See README_MONOREPO.md and docs/structure.md for more details on the monorepo structure.


Note

Switches the sidebar to use local SVG icon assets and adds the @veltdev/types dependency.

  • UI/Assets:
    • Update components/sidebar/sidebar.tsx to use local icon paths under public/icons/sidebar instead of remote URLs.
    • Add SVG icons in public/icons/sidebar/ (e.g., open-envoy-logo.svg, notifications.svg, divider.svg, etc.).
  • Dependencies:
    • Add @veltdev/types to package.json and lockfile.

Written by Cursor Bugbot for commit 303d79b. This will update automatically on new commits. Configure here.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Dec 16, 2025 •

Copy link
Copy Markdown

@yoen-velt
yoen-velt merged commit f9fea8c into main Dec 16, 2025
17 of 18 checks passed
@yoen-velt
yoen-velt deleted the fix/add-veltdev-types branch December 16, 2025 02:51

This branch was successfully deployed

15 active deployments
Preview – sample-apps-ag-grid-comment-aggregation — 303d79bf Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-ag-grid-single-tool — 303d79bf Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-ag-grid-multiple-tools — 303d79bf Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-tiptap-comments-demo — 303d79bf Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-tanstack-single-tool — 303d79bf Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-reactflow-demo — 303d79bf Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-tanstack-comment-aggregation — 303d79bf Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-tanstack-multiple-tools — 303d79bf Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-codemirror-crdt-demo — 303d79bf Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-slatejs-comments-demo — 303d79bf Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-tiptap-crdt-demo — 303d79bf Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-dashboard-demo — 303d79bf Deployed Dec 16, 2025 by vercel[bot]
Preview – sample-apps-lexical-comments-demo — 303d79bf Deployed Dec 16, 2025 by vercel[bot]
Preview – open-envoy-demo — 303d79bf Deployed Dec 16, 2025 by vercel[bot]
Preview – master-sample-app — 303d79bf Deployed Dec 16, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant