Skip to content

Added npm build and tests to CI - #2

Closed
dcbouius wants to merge 1 commit into
mainfrom
add-node-support-for-ci
Closed

dcbouius wants to merge 1 commit into
mainfrom
add-node-support-for-ci

Conversation

@dcbouius

Copy link
Copy Markdown

CI improvements:

  • Added concurrency settings to cancel in-progress runs
  • Renamed sdk-tests → python-sdk-tests
  • Added node-sdk-tests job with npm caching
  • Added npm caching to release workflow

Bug fix in sdk/node/src/index.ts:

  • Fixed cross-platform which/where detection that was creating a nul file

  CI improvements:
  - Added concurrency settings to cancel in-progress runs
  - Renamed sdk-tests → python-sdk-tests
  - Added node-sdk-tests job with npm caching
  - Added npm caching to release workflow

  Bug fix in sdk/node/src/index.ts:
  - Fixed cross-platform which/where detection that was creating a nul file

@nicoloboschi nicoloboschi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But I have plans to distribute the binary inside the npm package as we do for python now, also we don't have the npm package yet (as we don't need it for our projects for now)

@nicoloboschi

Copy link
Copy Markdown
Collaborator

Closing because we are intentionally removing the Node.js/npm SDK and its CI/release workflow rather than publishing @vectorize-io/pg0.

@nicoloboschi

Copy link
Copy Markdown
Collaborator

Superseded by the decision to drop Node.js/npm support entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants