Conversation
Adding .gitkeep for PR creation (created with --gitkeep-file flag). This file will be removed when the task is complete. Issue: veb86#760
…cking Key optimizations: 1. Replace string-based edge tracking with integer-based approach 2. Pre-allocate edge array based on face count 3. Cache vertex count to avoid repeated calls 4. Simplified edge visibility logic 5. Reduced code from 620+ lines to ~350 lines Performance improvements: - Eliminated expensive string operations (IntToStr, string concatenation) - Reduced memory allocations by pre-allocating array - Simplified duplicate detection with integer comparison - Added early exit for empty meshes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimized
GDBObjPolyFaceMesh.FormatEntityprocedure to significantly improve rendering performance of PolyFaceMesh entities.Problem
The original implementation had several performance issues:
IntToStrconversions for each edge comparisonSetLengthcalls growing array one element at a timeSolution
Key optimizations implemented:
VertexArrayInWCS.Countto avoid repeated callsPerformance Improvements
Testing
The algorithm maintains the same rendering logic:
Issue: #760