Repository navigation
Require exactly OhMyThreads 0.8.7 - #74
Merged
Merged
Conversation
OhMyThreads 0.8.8 changed how `tforeach` passes its output type to `Implementation._tmapreduce`, one of the internals the schedulers override, and with it the Enzyme rule for `run_chunks` throws a `CallingConventionMismatchError` on Julia >= 1.12 (#71). Since those internals can change in any 0.8 release (#30), allow only the release that is tested, and widen the bound release by release.
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OhMyThreads 0.8.8 broke the Enzyme rules for
run_chunkson Julia ≥ 1.12 (CallingConventionMismatchError, #71): it changed howtforeachpasses its output type toImplementation._tmapreduce, one of the OhMyThreads internals the schedulers override. Since those internals can change in any 0.8 release (#30), this allows only the tested release; the bound can be widened once JuliaFolds2/OhMyThreads.jl#177 is released and tested.Fixes #71.