Repository navigation
fix(settings): hide cloud sync from packaged builds - #1440
Merged
Merged
Conversation
The encrypted WebDAV configuration backup is not ready to be offered to packaged-build users yet. Reuse the existing development-only destination gate so shipped builds omit its rail row, page, and settings-search hits and fall back to General, while development builds keep the destination for continued work. Host sync behavior, IPC contracts, and persisted data are unchanged, so dropping the destination's developmentOnly flag reopens it. The specs and their zh-CN mirrors describe the gate, and decisions-log D649 records it as amending D642/D643.
The zh-CN plugin-marketplace page that the plugin-center move added linked `../../adr/0276-official-plugin-channel-and-backup-channels.md`, which resolves to `docs/zh-CN/adr`, where no ADR copy exists. VitePress failed the whole documentation build on that dead link, and the JS and Electron E2E jobs run the docs build too, so all three checks failed on `main`. Use the `/adr/...` form the other zh-CN pages already use for English ADRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The encrypted WebDAV configuration backup (Settings → Cloud sync) is not ready to be offered to packaged-build users yet. The destination entry in
apps/desktop/src/lib/settings-search.tscarriesdevelopmentOnly: trueagain, so:synctab falls back to General;Host sync behavior, the
configSync.*RPC contracts, the host schema, and persisted data are all unchanged, so dropping that one flag reopens the destination for packaged builds.Specs and their zh-CN mirrors record the gate (
04-ux/06-settings-ia.md,03-runtime/22-config-sync.md,03-runtime/01-ipc-protocol.md, the config-sync E2E entries), and decisions-log D649 records the decision as amending D642/D643.CI unblock (second commit)
mainatd403c9603fails Docs checks, JS build, and Trusted extensions Electron E2E becausedocs/zh-CN/spec/07-plugins/07-plugin-marketplace.mdlinks../../adr/0276-official-plugin-channel-and-backup-channels.md, which resolves todocs/zh-CN/adrwhere no ADR copy exists. VitePress fails the documentation build on that dead link, and both other jobs run the docs build. This PR repairs that one link with the/adr/...form the other zh-CN pages use, so the landing gates can actually run; it touches nothing else in the marketplace docs.Verification
node --test test/*.test.mjsinapps/desktop: 3580 pass / 0 failtsc -p tsconfig.json --noEmit: cleannode scripts/e2e-settings-scroll.mjs(real Electron, includes the Cloud sync visibility probe, compiled withimport.meta.env.DEVtrue):ok:truevitepress build .indocs: complete, no dead linksscripts/check-style-tokens.mjs,docs/scripts/check-locales.mjs(85 pairs),docs/scripts/check-docs.mjs(559 pages),git diff --check: cleanNo packaged build was launched; the packaged-only omission is covered by the
visibleSettingsNav(developerMode, false)assertions plusimport.meta.env.DEVbeing false underelectron-vite build, which is the same mechanism the Remote Hosts destination already uses.Known follow-up
Only the UI entry point is hidden. A user who already configured a vault keeps running background syncs, and the sync errors that the page used to surface are no longer visible in a packaged build. Disabling the background sync path itself would be a separate, host-side change.