fix: lagoon api token caching

[rocketeerbkw]

General Checklist

• Affected Issues have been mentioned in the Closing issues section
• Documentation has been written/updated
• PR title is ready for inclusion in changelog

Token caching can be broken for some users, meaning every invocation of the cli causes a token fetch. When using the cli in a loop in a bash script, this adds very significant overhead.

The bug is in the JWT parser. The StandardClaims Audience field is a string but a Lagoon token can be an array "aud": ["realm-management", "account"],. The ParseUnverified call errors with json: cannot unmarshal array into Go struct field StandardClaims.aud of type string but the error check return false silently, forcing a token fetch.

Using MapClaims{} is more forgiving and still validates the exp of the token.

Closing issues

n/a

[smlx]

Just to note here: v3 of golang-jwt is no longer supported and v5 does correctly support an array of audience string. Maybe upgrading would be better than working around this bug?