Skip to content

Update Go to v1.27.3 and use go.mod to get Go's version in the CI - #1164

Merged
urunc-bot[bot] merged 2 commits into
mainfrom
go-bump
Oct 29, 2026
Merged

urunc-bot[bot] merged 2 commits into
mainfrom
go-bump

Conversation

@cmainas

@cmainas cmainas commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Description

Update Go to v1.27.3 and use go.mod to get Go's version in the CI

Related issues

How was this tested?

with the CI in the PR

LLM usage

Opus 5.5

Checklist

  • I have read the contribution guide.
  • The linter passes locally (make lint).
  • The e2e tests of at least one tool pass locally (make test_ctr, make test_nerdctl, make test_docker, make test_crictl).
  • If LLMs were used: I have read the llm policy.

@netlify

netlify Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for urunc ready!

Name Link
🔨 Latest commit 3fbcc58
🔍 Latest deploy log https://app.netlify.com/projects/urunc/deploys/6ae33ff5de3a0efb0abf43c4
😎 Deploy Preview https://deploy-preview-1164--urunc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cmainas
cmainas force-pushed the go-bump branch 2 times, most recently from 3d34cbd to 33af6df Compare October 26, 2026 19:39
@cmainas
cmainas marked this pull request as ready for review October 26, 2026 20:47
@cmainas
cmainas requested a review from ananos October 26, 2026 20:47
@ananos

ananos commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

thanks @cmainas! Reading the version from go.mod removes all the CI copies (ci.yml, ci_main.yml, ci_nightly.yml, build.yml, lint.yml, unit_test.yml, vm_test.yml), and setup-go always runs after checkout. The setup-go logs show 1.27.3 for build, lint, unit and the "PR test code" e2e jobs, through the new toolchain line. As a side fix, a manual dispatch of build.yml no longer falls back to the runner's preinstalled Go.

A few nits:

  • The base e2e job checks out main (ci.yml:99), so go-version-file (vm_test.yml:103) resolves main's go.mod -- 1.26.8 in this run. The impact is small, since the binaries under test come from the 1.27.3 build job. But a future bump that touches only go.mod will not trigger the "PR test code" rerun (ci.yml:156-161). Maybe add go.mod to that list?
  • Two copies remain outside CI: deployment/urunc-deploy/Dockerfile:41 and docs/variables/versions.yml:2. The golang image ignores toolchain (GOTOOLCHAIN=local), dependabot does not bump that image, and the Dockerfile only builds after merge and nightly. We could add a small lint step that compares these with go.mod, or a bump checklist in Update Go version #1131.
  • 33af6df adds the toolchain line, which changes local go behavior for everyone, but has no body. One sentence would help, eg. "1.26.8 stays the minimum, 1.27.3 is what CI and the docs use."
  • (pre-existing, optional) docs/installation.md:516 says Go 1.20.6+ and docs/tutorials/knative.md:35 says 1.23+. The actual minimum is 1.26.8.

Rebase & merge replays cleanly on current main (12 commits, no conflicts in the Dockerfile or vm_test.yml). I intend to approve once you ack -- let me know if you want to address any of the above first.

@ananos ananos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @cmainas! LGTM.

PR: #1164
Signed-off-by: Charalampos Mainas <charalampos.mainas@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
Also set toolchain to 1.27.3 which is the version that the CI and docs
are using. Ye 1.26.8 remains the minimum version

PR: #1164
Signed-off-by: Charalampos Mainas <charalampos.mainas@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
@urunc-bot
urunc-bot Bot merged commit 6c5eb0e into main Oct 29, 2026
7 checks passed
urunc-bot Bot pushed a commit that referenced this pull request Oct 29, 2026
PR: #1164
Signed-off-by: Charalampos Mainas <charalampos.mainas@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
@cmainas
cmainas deleted the go-bump branch October 29, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants