Repository navigation
Conversation
Picks up the start_prereq_time_us, vmm_prestart_time_us and checkpoint_time_us instance fields that the spec only just started documenting. Signed-off-by: Justin Chadwell <justin@unikraft.com>
The platform only emits uptime, boot and net times once they are known, but the CLI mirrored them into plain durations, so a field the API never sent rendered as 0s whenever it was explicitly selected. Mirror them into pointers instead, so a missing field stays nil and prints blank, while a genuine zero still shows as 0s. Signed-off-by: Justin Chadwell <justin@unikraft.com>
The API reports the whole start sequence as offsets from the start request, but the CLI only surfaced boot and net time, so the stages before them were invisible. Mirror start-prereq, vmm-prestart, vmm-start, vmm-load and vmm-ready into the timing group, ordered as the timeline they form, and add the template and checkpoint creation times to their own resources. They are all long fields rather than hidden: the vmm ones are developer only on the platform side, so for everyone else they are simply absent. Signed-off-by: Justin Chadwell <justin@unikraft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API has had a bunch of boot timing fields the CLI never showed: the developer-only
vmm_*stages, plusstart_prereq_time_us,vmm_prestart_time_usandcheckpoint_time_uswhich only got into the spec with https://github.com/unikraft-cloud/platform-api/pull/22. Now-f timingshows the whole start sequence in order.Also fixes timing fields the API never sent rendering as
0swhen explicitly selected, since they're now mirrored into pointers.